mojo/services/authentication/public/interfaces/authentication.mojom - Issue 1163483004: Make the authentication service remember selected usernames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/authentication/public/interfaces/authentication.mojom

Issue 1163483004: Make the authentication service remember selected usernames. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/services/authentication/public/interfaces/authentication.mojom

diff --git a/mojo/services/authentication/public/interfaces/authentication.mojom b/mojo/services/authentication/public/interfaces/authentication.mojom

index a69e7de1a6853fd4063327b18ceca504710ba8cd..ea3fea6c64e52e690d2aea1de1130f2ef18a2d95 100644

--- a/mojo/services/authentication/public/interfaces/authentication.mojom

+++ b/mojo/services/authentication/public/interfaces/authentication.mojom

@@ -12,7 +12,8 @@ interface AuthenticationService {

// Requests a Google account to use. In case of success, error will be null.

// In case of error, username will be null and error will contain a

// description of the error.

- SelectAccount() => (string? username, string? error);

+ SelectAccount(bool returned_last_selected) =>

tonyg 2015/06/03 14:59:27 s/returned/use/ or at least s/returned/return/? A

qsr 2015/06/03 15:12:42 Done.

+ (string? username, string? error);

// Requests an oauth2 token for the given Google account with the given

// scopes. In case of error, username will be null and error will contain a

« no previous file with comments | « no previous file | services/authenticating_url_loader/authenticating_url_loader_factory_impl.cc » ('j') | no next file with comments »