services/authentication/authentication_impl_db.mojom - Issue 1163483004: Make the authentication service remember selected usernames.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/authentication/authentication_impl_db.mojom

Issue 1163483004: Make the authentication service remember selected usernames. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Update comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [JavaPackage="org.chromium.mojo.authentication"]

	6 module authentication;

	7

	8 // Database for the authentication implementation.

	9 struct Db {
	ppi 2015/06/03 17:11:17 Why are we defining this in a .mojom and not direc Why are we defining this in a .mojom and not directly in AuthenticationServiceImpl.java? ppi 2015/06/03 17:11:17 Oh, from the code it seems that we define that in Oh, from the code it seems that we define that in mojom so that we have serialization. Nifty:). If that is the case, could you please state in the comment that this struct is not actually passed between services? qsr 2015/06/04 09:16:15 Done. Show quoted text On 2015/06/03 17:11:17, ppi wrote: > Oh, from the code it seems that we define that in mojom so that we have > serialization. Nifty:). > > If that is the case, could you please state in the comment that this struct is > not actually passed between services? Done. qsr 2015/06/04 09:16:15 Acknowledged. Show quoted text On 2015/06/03 17:11:17, ppi wrote: > Why are we defining this in a .mojom and not directly in > AuthenticationServiceImpl.java? Acknowledged.
	10 // Version of the database.

	11 uint32 version;

	12 // Map from application to last selected account.

	13 map<string, string> last_selected_accounts;

	14 };

OLD	NEW