Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1163463005: Fix VPN dialog password field focus (Closed)

Created:
5 years, 6 months ago by stevenjb
Modified:
5 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VPN dialog password field focus See issue for details. BUG=493438 Committed: https://crrev.com/05aac8f3887f2f4f0f333fb7615054112bc4b620 Cr-Commit-Position: refs/heads/master@{#333067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stevenjb
bartfab@ - can you take a look at this change since pneubeck@ is out? The ...
5 years, 6 months ago (2015-06-03 22:23:29 UTC) #2
bartfab (slow)
lgtm
5 years, 6 months ago (2015-06-05 14:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163463005/1
5 years, 6 months ago (2015-06-05 16:18:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 16:45:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/05aac8f3887f2f4f0f333fb7615054112bc4b620 Cr-Commit-Position: refs/heads/master@{#333067}
5 years, 6 months ago (2015-06-05 16:46:57 UTC) #7
pneubeck (no reviews)
5 years, 6 months ago (2015-06-10 06:22:39 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698