Source/web/tests/PinchViewportTest.cpp - Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed outerViewport to layoutViewport Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index 43d7148be00a7311e93fb5a853ecd52d2256dba9..018801b9abe7f80e70196aa0b02e688826934b47 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -299,7 +299,7 @@ TEST_F(PinchViewportTest, TestResizeAfterVerticalScroll)

webViewImpl()->resize(IntSize(100, 200));

// Scroll main frame to the bottom of the document

- webViewImpl()->setMainFrameScrollOffset(WebPoint(0, 400));

+ webViewImpl()->mainFrame()->setScrollOffset(WebSize(0, 400));

EXPECT_POINT_EQ(IntPoint(0, 400), frame()->view()->scrollPosition());

webViewImpl()->setPageScaleFactor(2.0);

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | Source/web/tests/ProgrammaticScrollTest.cpp » ('j') | no next file with comments »