Source/web/WebViewImpl.h - Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed outerViewport to layoutViewport Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index aa5f6437e02c83d0272e5f906a5048bd1d4cce1c..48172b8dd795f2850c0c6c676d80369e17e57a9c 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -125,7 +125,7 @@ public:

virtual void applyViewportDeltas(

const WebFloatSize& pinchViewportDelta,

- const WebFloatSize& mainFrameDelta,

+ const WebFloatSize& layoutViewportDelta,

const WebFloatSize& elasticOverscrollDelta,

float pageScaleDelta,

float topControlsShownRatioDelta) override;

@@ -545,8 +545,6 @@ private:

void resumeTreeViewCommits();

IntSize contentsSize() const;

- void updateLayoutViewportScrollPosition(const DoublePoint& scrollPosition, bool programmaticScroll);

void performResize();

void resizeViewWhileAnchored(FrameView*);

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »