Source/web/FullscreenController.cpp - Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FullscreenController.cpp

Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed outerViewport to layoutViewport Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FullscreenController.cpp

diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp

index 176d064861d3a610bc7324262da3a8b631e26088..482026645a5ce5d284a138d835d16dc59b0fd503 100644

--- a/Source/web/FullscreenController.cpp

+++ b/Source/web/FullscreenController.cpp

@@ -78,7 +78,7 @@ void FullscreenController::didEnterFullScreen()

updatePageScaleConstraints(false);

m_webViewImpl->setPageScaleFactor(1.0f);

- m_webViewImpl->setMainFrameScrollOffset(IntPoint());

+ m_webViewImpl->mainFrame()->setScrollOffset(WebSize());

m_webViewImpl->setPinchViewportOffset(FloatPoint());

}

@@ -121,7 +121,7 @@ void FullscreenController::didExitFullScreen()

if (m_exitFullscreenPageScaleFactor) {

updatePageScaleConstraints(true);

m_webViewImpl->setPageScaleFactor(m_exitFullscreenPageScaleFactor);

- m_webViewImpl->setMainFrameScrollOffset(IntPoint(m_exitFullscreenScrollOffset));

+ m_webViewImpl->mainFrame()->setScrollOffset(WebSize(m_exitFullscreenScrollOffset));

m_webViewImpl->setPinchViewportOffset(m_exitFullscreenPinchViewportOffset);

m_exitFullscreenPageScaleFactor = 0;

m_exitFullscreenScrollOffset = IntSize();

« no previous file with comments | « Source/web/DevToolsEmulator.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »