Remove WebViewImpl helper methods for setting scroll offset.

Remove WebViewImpl helper methods for setting scroll offset.

Remove setMainFrameScrollOffset and updateLayoutViewportScrollOffset as
they're redundant and mostly used from tests anyway. Call sites were
modified to set the scroll offset on the main frame directly.

This patch is mostly a no-op cleanup. Semantics do change here slightly
since setMainFrameScrollOffset was calling updateLayoutViewportScrollOffset
with isProgrammatic=false, which is wrong. Also updated
WebLocalFrameImpl::setScrollOffset to call notifyScrollPositionChanged
rather than setScrollOffset since the latter doesn't update scrollbars,
animators, etc. and shouldn't be used directly.

Also, as a drive-by, replaced outerViewport/mainFrame with layoutViewport
in applyViewportDeltas since they're all refer to the same thing. Layout
viewport is the preferred terminology.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196421

[bokan, 2015-06-03 16:19:11]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 16:19:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163433003/40001

[bokan, 2015-06-03 16:20:08]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[bokan, 2015-06-03 16:20:58]

ptal, more cleanup split off from the mega-patch.

[skobes, 2015-06-03 16:57:57]

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebLocalFram...
File Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebLocalFram...
Source/web/WebLocalFrameImpl.cpp:694:
view->notifyScrollPositionChanged(IntPoint(offset.width, offset.height));
One step closer to making FrameView::setScrollOffset private :)

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebViewImpl....
Source/web/WebViewImpl.cpp:4276: ScrollableArea* layoutViewport =
frameView->layoutViewportScrollableArea();
It's confusing to use both "layout viewport" and "outer viewport" when they're
the same thing.  Can we either name this outerViewport, or change
outerViewportDelta to layoutViewportDelta?

[bokan, 2015-06-03 17:04:58]

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebLocalFram...
File Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebLocalFram...
Source/web/WebLocalFrameImpl.cpp:694:
view->notifyScrollPositionChanged(IntPoint(offset.width, offset.height));
On 2015/06/03 16:57:57, skobes wrote:
> One step closer to making FrameView::setScrollOffset private :)

I made it private in the mega patch :)

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/1163433003/diff/40001/Source/web/WebViewImpl....
Source/web/WebViewImpl.cpp:4276: ScrollableArea* layoutViewport =
frameView->layoutViewportScrollableArea();
On 2015/06/03 16:57:57, skobes wrote:
> It's confusing to use both "layout viewport" and "outer viewport" when they're
> the same thing.  Can we either name this outerViewport, or change
> outerViewportDelta to layoutViewportDelta?

Done.

[skobes, 2015-06-03 17:05:42]

lgtm

[bokan, 2015-06-03 17:27:58]

The CQ bit was checked by bokan@chromium.org

[bokan, 2015-06-03 17:28:02]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-06-03 17:28:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163433003/60001

[commit-bot: I haz the power, 2015-06-03 17:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 17:37:16]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[bokan, 2015-06-03 18:08:37]

bokan@chromium.org changed reviewers:
+ rbyers@chromium.org

[bokan, 2015-06-03 18:08:37]

+Rick for public/web change

[Rick Byers, 2015-06-03 18:23:04]

public/web LGTM

[bokan, 2015-06-03 18:23:30]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-06-03 18:24:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163433003/60001

[commit-bot: I haz the power, 2015-06-03 18:38:49]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196421