Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1163423007: Mark column sets as invalid and kill the interval tree when column sets are removed. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Mark column sets as invalid and kill the interval tree when column sets are removed. This makes the multicol code more fault-tolerant. If there are bugs somewhere in the engine that cause us to miss layout of objects marked for layout, the multicol code could return dead objects from the column set interval tree. Better just delete the interval tree right away when column sets are removed, instead of keeping dead objects around. The tree will be rebuilt during layout. To clarify: This CL doesn't really fix bug 498664, but at least we won't crash because of accessing dead objects anymore (only assert in LayoutObject::assertLaidOut() and other places, like before). BUG=498664 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
No test in this CL, since the problem that this CL fixes depends on other ...
5 years, 6 months ago (2015-06-10 10:46:08 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-10 14:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163423007/1
5 years, 6 months ago (2015-06-10 14:22:30 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:16:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196876

Powered by Google App Engine
This is Rietveld 408576698