Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1163403006: DevTools: Tweak frames band overview drawing (Closed)

Created:
5 years, 6 months ago by alph
Modified:
5 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Tweak frames band overview drawing - Make fill color more pale - Add small marks to visually separate frames - Move frame band to the bottom of the overview - Fix last frame drawing BUG=497031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alph
ptal. It's still an experiment.
5 years, 6 months ago (2015-06-09 12:08:19 UTC) #2
yurys
lgtm
5 years, 6 months ago (2015-06-09 12:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163403006/1
5 years, 6 months ago (2015-06-09 12:14:49 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 13:22:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196761

Powered by Google App Engine
This is Rietveld 408576698