Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1163373005: Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/1171943002/) Reason for revert: might break stuff Original issue's description: > [test] Refactoring - Use subject/observer pattern for progress indicators. > > This should prevent bugs caused by missing super calls in > overridden methods. The assumption is that methods of > different indicators are independent. > > Committed: https://crrev.com/fbe973ff1722a6158a5b2babce9c1a32d26a1d3b > Cr-Commit-Position: refs/heads/master@{#28866} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2a3962d9d2a7415378811f4d56522531332d5a3e Cr-Commit-Position: refs/heads/master@{#28869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M tools/run-tests.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/local/progress.py View 7 chunks +31 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
Created Revert of [test] Refactoring - Use subject/observer pattern for progress indicators.
5 years, 6 months ago (2015-06-09 15:31:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163373005/1
5 years, 6 months ago (2015-06-09 15:32:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 15:32:43 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a3962d9d2a7415378811f4d56522531332d5a3e Cr-Commit-Position: refs/heads/master@{#28869}
5 years, 6 months ago (2015-06-09 15:33:00 UTC) #4
tandrii(chromium)
lgtm
5 years, 6 months ago (2015-06-09 15:59:48 UTC) #5
Michael Achenbach
5 years, 6 months ago (2015-06-10 09:42:09 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1176863002/ by machenbach@chromium.org.

The reason for reverting is: All build problems had other causes..

Powered by Google App Engine
This is Rietveld 408576698