Issue 1163323007: Make it possible to navigate from a SkyView to a WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163323007: Make it possible to navigate from a SkyView to a WebView. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Cutch, WRONG ACCOUNT, abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make it possible to navigate from a SkyView to a WebView. This would occur when bringing SkyDemo to the front after having viewed a SkyView based demo and then paused the SkyActivity (by going to the Android Launcher, etc.) I also fixed deploy_domokit_site.py to ignore .gitignore files found in packages. We should actually probably ignore these when creating the packages in the first place, but this check seems valid regardless. The .gitignore for sky/lib/assets was causing the assets not to get pushed to the demo site. R=abarth@chromium.org, johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/20191021269c4e715c010148e8232e2780c5bfee

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	mojo/tools/deploy_domokit_site.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	sky/shell/ui/engine.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

5 years, 6 months ago (2015-06-09 22:10:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
20191021269c4e715c010148e8232e2780c5bfee (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages