Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1163323006: Speed up ExpressionClassifier::Accumulate (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up ExpressionClassifier::Accumulate The following changeset introduced a regression on CodeLoad of about 3%: https://chromium.googlesource.com/v8/v8/+/e73594c7fb3e6b5834b7ddfe78727fb994bab25f This CL should reduce the regression to 1.5%. R=dslomov@chromium.org LOG=N BUG= Committed: https://crrev.com/5e1862fee85cbcc77abd6156a2721eed786a2ad9 Cr-Commit-Position: refs/heads/master@{#28872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -45 lines) Patch
M src/preparser.h View 10 chunks +66 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
5 years, 6 months ago (2015-06-09 14:45:45 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 6 months ago (2015-06-09 14:49:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163323006/1
5 years, 6 months ago (2015-06-09 14:53:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 15:59:02 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 15:59:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e1862fee85cbcc77abd6156a2721eed786a2ad9
Cr-Commit-Position: refs/heads/master@{#28872}

Powered by Google App Engine
This is Rietveld 408576698