Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1163323004: Removing unecessary button label (Closed)

Created:
5 years, 6 months ago by dominickn (DO NOT USE)
Modified:
5 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unecessary button label Remove the Cancel button from the app banner infobar on desktop. This makes the infobar consistent with the mobile implementation, which only has an Accept button and a dismissal X. BUG=491001 R=benwells Committed: https://crrev.com/68736e1c6c8edec4d7c3627f815488fdd30e4263 Cr-Commit-Position: refs/heads/master@{#333720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_infobar_delegate_desktop.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_infobar_delegate_desktop.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dominickn (DO NOT USE)
5 years, 6 months ago (2015-06-09 23:41:05 UTC) #3
benwells
lgtm
5 years, 6 months ago (2015-06-10 04:14:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163323004/1
5 years, 6 months ago (2015-06-10 11:03:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 11:50:46 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 11:51:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68736e1c6c8edec4d7c3627f815488fdd30e4263
Cr-Commit-Position: refs/heads/master@{#333720}

Powered by Google App Engine
This is Rietveld 408576698