sky/engine updates for iOS targets

sky/engine updates for iOS targets

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/eb7f1a5e4e7d58031a5ee30dac9f502b938ccaec

[abarth-chromium, 2015-06-08 20:32:30]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-08 20:32:31]

lgtm

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
File sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp (right):

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp:29: */
Where does this copyright block come from?  We usually just use:

// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp:32: #include
"sky/engine/config.h"
We always put config.h first, followed by the "primary header" (in this case
FontPlatformData.h), followed by a blank line, followed by the rest of the
headers sorted alpahbetaically.

[Chinmay, 2015-06-08 20:36:21]

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
File sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp (right):

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp:29: */
On 2015/06/08 at 20:32:31, abarth wrote:
> Where does this copyright block come from?  We usually just use:
> 
> // Copyright 2015 The Chromium Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.

I used FontPlatformDataLinux as a template. Should I switch to use this instead?

https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp:32: #include
"sky/engine/config.h"
On 2015/06/08 at 20:32:31, abarth wrote:
> We always put config.h first, followed by the "primary header" (in this case
FontPlatformData.h), followed by a blank line, followed by the rest of the
headers sorted alpahbetaically.

Noted. Will fix.

[abarth-chromium, 2015-06-08 20:37:27]

On 2015/06/08 at 20:36:21, chinmaygarde wrote:
>
https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
> File sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp (right):
> 
>
https://codereview.chromium.org/1163323003/diff/1/sky/engine/platform/fonts/i...
> sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp:29: */
> On 2015/06/08 at 20:32:31, abarth wrote:
> > Where does this copyright block come from?  We usually just use:
> > 
> > // Copyright 2015 The Chromium Authors. All rights reserved.
> > // Use of this source code is governed by a BSD-style license that can be
> > // found in the LICENSE file.
> 
> I used FontPlatformDataLinux as a template. Should I switch to use this
instead?

I see.  In that case, you're right to keep the licence block.

[Chinmay, 2015-06-10 23:18:07]

Committed patchset #1 (id:1) manually as
eb7f1a5e4e7d58031a5ee30dac9f502b938ccaec (presubmit successful).