Implemented class literals in the VM.

tests/language/class_literal_test.dart

Index: tests/language/class_literal_test.dart
===================================================================
--- tests/language/class_literal_test.dart	(revision 16343)
+++ tests/language/class_literal_test.dart	(working copy)
@@ -12,31 +12,19 @@
 
 main() {
   if (false) {
-    Class; /// 01: compile-time error
     Class(); /// 02: compile-time error
-    Class.method(); /// 03: static type warning
-    Class.field; /// 04: static type warning
     Class[0]; /// 05: compile-time error
-    var x = Class; /// 06: compile-time error
     var x = Class(); /// 07: compile-time error
-    var x = Class.method(); /// 08: static type warning
-    var x = Class.field; /// 09: static type warning
     var x = Class[0]; /// 10: compile-time error
     var x = Class[0].field; /// 11: compile-time error
     var x = Class[0].method(); /// 12: compile-time error
-    foo(Class); /// 13: compile-time error
     foo(Class()); /// 14: compile-time error
-    foo(Class.method()); /// 15: static type warning
-    foo(Class.field); /// 16: static type warning
     foo(Class[0]); /// 17: compile-time error
     foo(Class[0].field); /// 18: compile-time error
     foo(Class[0].method()); /// 19: compile-time error
-    Class == null; /// 20: compile-time error
-    null == Class; /// 21: compile-time error
     Class[0] = 91; /// 22: compile-time error
     Class++; /// 23: compile-time error
     ++Class; /// 24: compile-time error
-    Class / 3; /// 25: compile-time error
     Class += 3; /// 26: compile-time error
     Class[0] += 3; /// 27: compile-time error
     ++Class[0]; /// 28: compile-time error
@@ -44,4 +32,33 @@
   }
   Expect.equals(42, Class.fisk());
   Expect.equals(null, foo(Class.fisk()));
+  
+  // Verify references to a class literal are allowed.
+  Class;
+  var x = Class;
+  foo(Class);
+  Expect.isFalse(Class == null);
+
+  // Verify that dereferencing a class literal is a runtime error.
+  Expect.throws(() { Class.method(); }, (e) => e is NoSuchMethodError);

[hausner, 2012/12/21 00:31:43]

This is probably still a static type warning, in addition to a runtime error.
Does the analyzer test pass without annotating the warning? Ditto for many of
the cases below.

+  Expect.throws(() { Class.field; }, (e) => e is NoSuchMethodError);
+  Expect.throws(() { var x = Class.method(); }, (e) => e is NoSuchMethodError);
+  Expect.throws(() { var x = Class.field; }, (e) => e is NoSuchMethodError);
+  Expect.throws(() { foo(Class.method()); }, (e) => e is NoSuchMethodError);
+  Expect.throws(() { foo(Class.field); }, (e) => e is NoSuchMethodError);
+  Expect.throws(() { Class / 3; }, (e) => e is NoSuchMethodError);
+
+  // Verify that a class literal is its runtimeType.
+  var obj = new Class();
+  Expect.identical(Class, obj.runtimeType);
+  
+  // Verify that a class literal isn't a string literal.
+  Expect.notEquals(Class, "Class");
+   
+  // Verify toString() works for class literals.
+  Expect.equals((Class).toString(), "Class");
+  
+  // This fails because toString() is not static -- need spec decision

[regis, 2012/12/21 00:09:10]

How about
vax x = Class;
Expect.equals(x.toString(), "Class");

[Tom Ball, 2012/12/21 22:24:11]

Added.  I also removed the comment about needing a spec decision, as it was
decided to tackle that issue when classes are made first-class types.

+  // on whether this should work (fails the law of least astonishment).
+  Expect.throws(() { Class.toString(); }, (e) => e is NoSuchMethodError);

[regis, 2012/12/21 00:09:10]

You do not have any tests for type parameters.

[Tom Ball, 2012/12/21 22:24:11]

Right -- I took Ivan's example test and created
tests/language/type_parameter_literal_test.dart, and marked it as failing for
now.

 }