chrome/browser/ui/webui/constrained_web_dialog_ui.h - Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_ui.h

Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use gtk_widget_get_toplevel for GetNativeWindow Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/constrained_web_dialog_ui.h

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_ui.h b/chrome/browser/ui/webui/constrained_web_dialog_ui.h

index ea1e2ca67578fc838b52b3bcc06ef23a8ab24f6b..791e0bf4fc8e74a12940f16a2372513bd4534a44 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_ui.h

+++ b/chrome/browser/ui/webui/constrained_web_dialog_ui.h

@@ -8,7 +8,7 @@

#include "base/compiler_specific.h"

#include "content/public/browser/web_ui_controller.h"

-class ConstrainedWindow;

+class WebContentsModalDialog;

namespace content {

class BrowserContext;

@@ -35,8 +35,8 @@ class ConstrainedWebDialogDelegate {

// released WebContents.

virtual void ReleaseWebContentsOnDialogClose() = 0;

- // Returns the ConstrainedWindow.

- virtual ConstrainedWindow* GetWindow() = 0;

+ // Returns the WebContentsModalDialog.

+ virtual WebContentsModalDialog* GetWindow() = 0;

// Returns the WebContents owned by the constrained window.

virtual content::WebContents* GetWebContents() = 0;

@@ -47,9 +47,9 @@ class ConstrainedWebDialogDelegate {

// ConstrainedWebDialogUI is a facility to show HTML WebUI content

// in a tab-modal constrained dialog. It is implemented as an adapter

-// between an WebDialogUI object and a ConstrainedWindow object.

+// between an WebDialogUI object and a WebContentsModalDialog object.

-// Since ConstrainedWindow requires platform-specific delegate

+// Since WebContentsModalDialog requires platform-specific delegate

// implementations, this class is just a factory stub.

// TODO(thestig): Refactor the platform-independent code out of the

// platform-specific implementations.