Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5621)

Unified Diff: chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h

Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use gtk_widget_get_toplevel for GetNativeWindow Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h
diff --git a/chrome/browser/ui/constrained_window_tab_helper_delegate.h b/chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h
similarity index 34%
rename from chrome/browser/ui/constrained_window_tab_helper_delegate.h
rename to chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h
index d7de24ea42325426b17f6215cba71b8cc802655e..382e1256574a42b6d7130e59348b617ea7a05bdf 100644
--- a/chrome/browser/ui/constrained_window_tab_helper_delegate.h
+++ b/chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_CONSTRAINED_WINDOW_TAB_HELPER_DELEGATE_H_
-#define CHROME_BROWSER_UI_CONSTRAINED_WINDOW_TAB_HELPER_DELEGATE_H_
+#ifndef CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_DELEGATE_H_
+#define CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_DELEGATE_H_
namespace content {
class WebContents;
@@ -13,26 +13,27 @@ namespace gfx {
class Point;
}
-class ConstrainedWindowTabHelperDelegate {
+class WebContentsModalDialogManagerDelegate {
public:
- // Returns true if constrained windows should be focused. Default is true.
- virtual bool ShouldFocusConstrainedWindow();
+ // Returns true if WebContentsModalDialogs should be focused. Default is true.
+ virtual bool ShouldFocusWebContentsModalDialog();
// Changes the blocked state of |web_contents|. WebContentses are considered
- // blocked while displaying a tab modal dialog. During that time renderer host
- // will ignore any UI interaction within WebContents outside of the
- // currently displaying dialog.
+ // blocked while displaying a web contents modal dialog. During that time
+ // renderer host will ignore any UI interaction within WebContents outside of
+ // the currently displaying dialog.
virtual void SetWebContentsBlocked(content::WebContents* web_contents,
bool blocked);
- // Fills in |point| with the coordinates for positioning chrome style
- // constrained windows. The constrained window should position itself such
- // that its top center is at |point|. Return false if the default position
- // should be used.
+ // Fills in |point| with the coordinates for positioning web contents modal
+ // dialogs. The dialog should position itself such that its top center is at
+ // |point|. Return false if the default position should be used.
+ // TODO(wittman): Remove this function once we have migrated positioning
+ // functionality to a ShowDialog function on WebContentsModalDialogManager.
virtual bool GetDialogTopCenter(gfx::Point* point);
protected:
- virtual ~ConstrainedWindowTabHelperDelegate();
+ virtual ~WebContentsModalDialogManagerDelegate();
};
-#endif // CHROME_BROWSER_UI_CONSTRAINED_WINDOW_TAB_HELPER_DELEGATE_H_
+#endif // CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698