Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/ui/gtk/constrained_window_gtk.cc

Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use gtk_widget_get_toplevel for GetNativeWindow Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/constrained_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/constrained_window_gtk.cc b/chrome/browser/ui/gtk/constrained_window_gtk.cc
index 2894dbc09f728323f331777691d5fbc49a0fae1e..dbe8958747fadae84b1cafb3142d7c8de28650c8 100644
--- a/chrome/browser/ui/gtk/constrained_window_gtk.cc
+++ b/chrome/browser/ui/gtk/constrained_window_gtk.cc
@@ -9,10 +9,10 @@
#include "base/bind.h"
#include "base/message_loop.h"
#include "chrome/browser/ui/browser_list.h"
-#include "chrome/browser/ui/constrained_window_tab_helper.h"
-#include "chrome/browser/ui/constrained_window_tab_helper_delegate.h"
#include "chrome/browser/ui/gtk/gtk_util.h"
#include "chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h"
+#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
+#include "chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/gtk/focus_store_gtk.h"
@@ -73,9 +73,9 @@ ConstrainedWindowGtk::ConstrainedWindowGtk(
g_signal_connect(widget(), "hierarchy-changed",
G_CALLBACK(OnHierarchyChangedThunk), this);
- ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- constrained_window_tab_helper->AddDialog(this);
+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ web_contents_modal_dialog_manager->AddDialog(this);
}
ConstrainedWindowGtk::~ConstrainedWindowGtk() {
@@ -96,9 +96,9 @@ void ConstrainedWindowGtk::CloseWebContentsModalDialog() {
if (visible_)
ContainingView()->RemoveConstrainedWindow(this);
delegate_->DeleteDelegate();
- ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- constrained_window_tab_helper->WillClose(this);
+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ web_contents_modal_dialog_manager->WillClose(this);
delete this;
}
@@ -110,10 +110,10 @@ void ConstrainedWindowGtk::FocusWebContentsModalDialog() {
// The user may have focused another tab. In this case do not grab focus
// until this tab is refocused.
- ConstrainedWindowTabHelper* helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- if ((!helper->delegate() ||
- helper->delegate()->ShouldFocusConstrainedWindow()) &&
+ WebContentsModalDialogManager* manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ if ((!manager->delegate() ||
+ manager->delegate()->ShouldFocusWebContentsModalDialog()) &&
gtk_util::IsWidgetAncestryVisible(focus_widget)) {
gtk_widget_grab_focus(focus_widget);
} else {
@@ -121,6 +121,17 @@ void ConstrainedWindowGtk::FocusWebContentsModalDialog() {
}
}
+void ConstrainedWindowGtk::PulseWebContentsModalDialog() {
+}
+
+bool ConstrainedWindowGtk::CanShowWebContentsModalDialog() {
+ return true;
+}
+
+gfx::NativeWindow ConstrainedWindowGtk::GetNativeWindow() {
+ return GTK_WINDOW(gtk_widget_get_toplevel(widget()));
+}
+
void ConstrainedWindowGtk::BackgroundColorChanged() {
GdkColor background;
if (delegate_->GetBackgroundColor(&background)) {
« no previous file with comments | « chrome/browser/ui/gtk/constrained_window_gtk.h ('k') | chrome/browser/ui/gtk/ssl_client_certificate_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698