chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h - Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h

Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use gtk_widget_get_toplevel for GetNativeWindow Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.mm ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h b/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h

index d451d7001c3474278630984d6cc8976a793e192c..18b3dacf5cb32a066764fbb7dd7d0488889131db 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h

@@ -12,11 +12,11 @@

// A NSWindow subclass that gives a custom look (rounded corners and white

// background).

-// Unfortunately the word "window" here is overused. ConstrainedWindow is the

-// tab modal dialog controller. ConstrainedWindowCustomWindow is the custom

-// NSWindow that gives us the new look (rounded corners and white background).

+// Note that WebContentsModalDialog is the web contents modal dialog

+// controller. ConstrainedWindowCustomWindow is the custom NSWindow that gives

+// us the new look (rounded corners and white background).

-// If a ConstrainedWindow is using ConstrainedWindowAlert to display its UI

+// If a WebContentsModalDialog is using ConstrainedWindowAlert to display its UI

// then it doesn't have to use this class. On the other hand, if it has some

// custom UI (say from a nib) then it should use this class.

@interface ConstrainedWindowCustomWindow : ChromeEventProcessingWindow