content/browser/devtools/devtools_agent_host.h - Issue 11633035: DevTools: prepare workers for DevToolsManager::Attach(Detach)ClientHost removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host.h

Issue 11633035: DevTools: prepare workers for DevToolsManager::Attach(Detach)ClientHost removal. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Patch for landing Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_agent_host.h

diff --git a/content/browser/devtools/devtools_agent_host.h b/content/browser/devtools/devtools_agent_host.h

index ae44862bf1dda1c9ca68b12beabecc8201311b8c..1bafdcd132479dae1adea877daa3b985e7adb6eb 100644

--- a/content/browser/devtools/devtools_agent_host.h

+++ b/content/browser/devtools/devtools_agent_host.h

@@ -29,7 +29,7 @@ class CONTENT_EXPORT DevToolsAgentHost {

// Sends the message to the devtools agent hosted by this object.

void Attach();

void Reattach(const std::string& saved_agent_state);

- void Detach();

+ virtual void Detach();

void DipatchOnInspectorBackend(const std::string& message);

void InspectElement(int x, int y);

void AddMessageToConsole(ConsoleMessageLevel level,

@@ -49,7 +49,7 @@ class CONTENT_EXPORT DevToolsAgentHost {

virtual void NotifyClientAttaching() = 0;

virtual void NotifyClientDetaching() = 0;

- void NotifyCloseListener();

+ bool NotifyCloseListener();

CloseListener* close_listener_;

};

« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host.cc » ('j') | no next file with comments »