content/browser/devtools/devtools_manager_impl.cc - Issue 11633035: DevTools: prepare workers for DevToolsManager::Attach(Detach)ClientHost removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_manager_impl.cc

Issue 11633035: DevTools: prepare workers for DevToolsManager::Attach(Detach)ClientHost removal. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_agent_host.h ('k') | content/browser/devtools/worker_devtools_manager.h » ('j') | content/browser/devtools/worker_devtools_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_manager_impl.cc

diff --git a/content/browser/devtools/devtools_manager_impl.cc b/content/browser/devtools/devtools_manager_impl.cc

index b548ba2219b2132ddff6a11368ba2cdbdd1ef0a7..c27984c1a9ac9c0ad2e8140a2d931f251903f60b 100644

--- a/content/browser/devtools/devtools_manager_impl.cc

+++ b/content/browser/devtools/devtools_manager_impl.cc

@@ -270,9 +270,12 @@ void DevToolsManagerImpl::UnbindClientHost(DevToolsAgentHost* agent_host,

FROM_HERE,

base::Bind(&DevToolsNetLogObserver::Detach));

}

+ int process_id = agent_host->GetRenderProcessId();

+ // Lazy agent hosts can be deleted from within detach.

+ // Do not access agent_host below this line.

agent_host->Detach();

- int process_id = agent_host->GetRenderProcessId();

if (process_id == -1)

return;

for (AgentToClientHostMap::iterator it = agent_to_client_host_.begin();