content/browser/frame_host/frame_tree_node.cc - Issue 1163303003: PlzNavigate: Create the speculative renderer earlier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 1163303003: PlzNavigate: Create the speculative renderer earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed clamy's comments; moved RFHM::BeginNavigation call into FTN::SetNavigationRequest. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/frame_tree_node.cc

diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc

index 08254c9d2d44aafdbfd321f9c38e379bde819bee..8dec84723b50fd11799476cafe983a6fd437f7c4 100644

--- a/content/browser/frame_host/frame_tree_node.cc

+++ b/content/browser/frame_host/frame_tree_node.cc

@@ -219,6 +219,8 @@ void FrameTreeNode::SetNavigationRequest(

}

navigation_request_ = navigation_request.Pass();

+ render_manager()->BeginNavigation(*navigation_request_);

clamy 2015/06/09 16:01:29 Please rename the function in RFHM DidSetNavigatio

carlosk 2015/06/10 11:53:08 Done.

}

void FrameTreeNode::ResetNavigationRequest(bool is_commit) {

« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.h » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')