Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/quic_client_session.cc

Issue 11633030: Send the ClientHello handshake message. Fix a bug in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix QuicStreamFactoryTest properly Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/quic/crypto/crypto_protocol.cc ('K') | « net/quic/quic_client_session.h ('k') | net/quic/quic_client_session_test.cc » ('j') | net/quic/quic_client_session_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.cc
===================================================================
--- net/quic/quic_client_session.cc (revision 174485)
+++ net/quic/quic_client_session.cc (working copy)
@@ -53,9 +53,10 @@
};
int QuicClientSession::CryptoConnect(const CompletionCallback& callback) {
- CryptoHandshakeMessage message;
- message.tag = kCHLO;
- crypto_stream_.SendHandshakeMessage(message);
+ if (!crypto_stream_.CryptoConnect()) {
+ // TODO(wtc): map to a net error code.
Ryan Hamilton 2012/12/22 22:31:32 Not sure about this comment. Isn't ERR_CONNECTION
+ return ERR_CONNECTION_FAILED;
+ }
if (IsCryptoHandshakeComplete()) {
return OK;
« net/quic/crypto/crypto_protocol.cc ('K') | « net/quic/quic_client_session.h ('k') | net/quic/quic_client_session_test.cc » ('j') | net/quic/quic_client_session_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698