Send the ClientHello handshake message. Fix a bug in

net/quic/quic_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Some helpers for quic
 
 #ifndef NET_QUIC_QUIC_UTILS_H_
 #define NET_QUIC_QUIC_UTILS_H_
 
 #include "net/base/int128.h"
 #include "net/base/net_export.h"
 #include "net/quic/quic_protocol.h"
 
 namespace gfe2 {
   class BalsaHeaders;
 }
 
 namespace net {
 
+class QuicClientHelloConfig;
+class QuicClock;
+class QuicRandom;
+struct CryptoHandshakeMessage;
+
 class NET_EXPORT_PRIVATE QuicUtils {
  public:
   // The overhead the quic framing will add for a packet with num_frames
   // frames.
   static size_t StreamFramePacketOverhead(int num_frames);
 
   // returns the 128 bit FNV1a hash of the data.  See
   // http://www.isthe.com/chongo/tech/comp/fnv/index.html#FNV-param
   static uint128 FNV1a_128_Hash(const char* data, int len);
 
   // Returns the name of the quic error code as a char*
   static const char* ErrorToString(QuicErrorCode error);
+
+  // Generates the connection nonce.
+  static void GenerateNonce(const QuicClock* clock,
+                            QuicRandom* random_generator,
+                            std::string* nonce);
+
+  static void FillClientHelloMessage(const QuicClientHelloConfig& config,

[Ryan Hamilton, 2012/12/22 22:31:32]

I think you'll end up wanting the inverse of this method for ease of testing and
for handling server side.  Doesn't need to be added in this CL, though it would
make your CheckClientHelloMessage method easier to implement.

+                                     const std::string& nonce,

[Ryan Hamilton, 2012/12/22 22:31:32]

nit: add #include <string>

+                                     CryptoHandshakeMessage* message);

[wtc, 2012/12/22 04:21:51]

Is QuicUtils the right home for these two utility functions?
Or should I add a HandshakeUtils class for them?

[Ryan Hamilton, 2012/12/22 22:31:32]

This is fine.  I think I'd probably create a CryptoUtils class.  Either way,
though.

 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_UTILS_H_