ash/wm/base_layout_manager.cc - Issue 11633029: Remove ash::window::Show() from BaseLayoutManager::OnWindowActivated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/base_layout_manager.cc

Issue 11633029: Remove ash::window::Show() from BaseLayoutManager::OnWindowActivated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/base_layout_manager.cc

===================================================================

--- ash/wm/base_layout_manager.cc (revision 173773)

+++ ash/wm/base_layout_manager.cc (working copy)

@@ -154,10 +154,6 @@

void BaseLayoutManager::OnWindowActivated(aura::Window* gained_active,

aura::Window* lost_active) {

- if (gained_active && wm::IsWindowMinimized(gained_active)) {

Ben Goodger (Google) 2013/01/07 22:10:18 Can you try running ash_unittests with --use-focus

- gained_active->Show();

- DCHECK(!wm::IsWindowMinimized(gained_active));

- }

}

//////////////////////////////////////////////////////////////////////////////

« no previous file with comments | « no previous file | no next file » | no next file with comments »