Issue 3223. Don't report warning when call variable with not-function inferred type.

Issue 3223. Don't report warning when call variable with not-function inferred type.
http://code.google.com/p/dart/issues/detail?id=3223


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=16356

[Brian Wilkerson, 2012-12-19 21:23:40]

LGTM, although I have to wonder whether this will stop reporting errors in some
places where it ought to. Have you tried it with code of the form:

method m() {
  num n = 1;
  n();
}

In other words, does disabling warnings for inferred types disable warnings even
when the static type would justify a warning?

https://codereview.chromium.org/11633024/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://codereview.chromium.org/11633024/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1030: if
(!types.isAssignable(t, s)) {
I believe that 1029 - 1034 could be replaced by "return types.isAssignable(t,
s);", which would be cleaner.

[scheglov, 2012-12-20 00:59:44]

We don't override type when of variable when it is specified explicitly.
So, this code still gives warning.

void m() {
  num n = 1;
  n();
}

https://codereview.chromium.org/11633024/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://codereview.chromium.org/11633024/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1030: if
(!types.isAssignable(t, s)) {
On 2012/12/19 21:23:40, Brian Wilkerson wrote:
> I believe that 1029 - 1034 could be replaced by "return types.isAssignable(t,
> s);", which would be cleaner.

Done.