update portable fonts

Today's gm include many differences caused by platform font implementations.
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.

Since there is no way today to generate all dm output from trybots, 
this will be checked in to confirm that this strategy provides simpler 
output across devices.

This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.

Committed: https://skia.googlesource.com/skia/+/83ca628cb6c959524edc3a696d7c3b5f7f1826ba

[caryclark, 2015-06-08 18:32:44]

caryclark@google.com changed reviewers:
+ bungeman@gmail.com, mtklein@google.com, reed@google.com

[caryclark, 2015-06-08 18:32:54]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-06-08 18:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/50001

[commit-bot: I haz the power, 2015-06-08 18:33:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-06-09 00:33 UTC

[caryclark, 2015-06-08 19:14:21]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-06-08 19:15:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/70001

[caryclark, 2015-06-08 20:07:28]

please take a look

[bungeman-skia, 2015-06-08 20:11:54]

bungeman@google.com changed reviewers:
+ bungeman@google.com
- bungeman@gmail.com

[bungeman-skia, 2015-06-08 20:28:35]

Will this work with the serialized gms? It seems like the default font would be
used in the serialize configurations in dm.

[commit-bot: I haz the power, 2015-06-09 00:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 00:33:06]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[caryclark, 2015-06-09 13:11:33]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 13:11:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/80001

[commit-bot: I haz the power, 2015-06-09 13:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 13:13:21]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[caryclark, 2015-06-09 13:30:49]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 13:31:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/90001

[commit-bot: I haz the power, 2015-06-09 13:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 13:36:29]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-06-09 14:24:59]

The latest serializes correctly from DM. Feel free to suggest a more agreeable
way of implementing the typeface delegate function.

[mtklein, 2015-06-09 14:39:49]

I like this.

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp#newcode714
dm/DM.cpp:714: static SkTypeface* CreateFromName(const char familyName[],
SkTypeface::Style style) {
create_from_name?

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp#newcode729
dm/DM.cpp:729: SkTypeface::AddCreateDelegate(&CreateFromName);
Perhaps we could inline this into main.

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypefac...
include/core/SkTypeface.h:324: static void AddCreateDelegate(SkTypeface*
(*delegate)(const char [], SkTypeface::Style )) {
Something like SetGlobalCreateFromNameDelegate?  Particularly keen to get Set in
there so it's clear There Can Be Only One, and Global to remind us it's, well,
global.

Alternatively, if we want to make this a little more backdoor-y, less public, we
could just drop this function entirely, make the function pointer a non-static
global, and have DM declare and set it manually?

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
File tools/sk_tool_utils_font.cpp (right):

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
tools/sk_tool_utils_font.cpp:50: SkDebugf("missing %s %d\n", name, style);
Should we consider just crashing here instead?

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
tools/sk_tool_utils_font.cpp:51: SkAutoTUnref<SkFontMgr>
fm(SkFontMgr::RefDefault());
Is this something like

// If we called SkTypeface::CreateFromName() here we'd recurse infinitely,
// so we reimplement its core logic here inline without the recursive aspect.

?

[bungeman-skia, 2015-06-09 14:47:51]

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypefac...
include/core/SkTypeface.h:419: static SkTypeface* (*fCreateDelegate)(const char
name[], SkTypeface::Style style);
We often have a typedef (and end it with Proc) to make things a bit shorter so
maybe have a

using NameDelegateProc = SkTypeface* (*)(const char name[], SkTypeface::Style
style);

We're already using this type in three places, so it would be nice to have a
name so we're not repeating.

[caryclark, 2015-06-09 16:37:21]

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp#newcode714
dm/DM.cpp:714: static SkTypeface* CreateFromName(const char familyName[],
SkTypeface::Style style) {
On 2015/06/09 14:39:48, mtklein wrote:
> create_from_name?

Done.

https://codereview.chromium.org/1163283002/diff/100001/dm/DM.cpp#newcode729
dm/DM.cpp:729: SkTypeface::AddCreateDelegate(&CreateFromName);
On 2015/06/09 14:39:48, mtklein wrote:
> Perhaps we could inline this into main.

Done.

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypefac...
include/core/SkTypeface.h:324: static void AddCreateDelegate(SkTypeface*
(*delegate)(const char [], SkTypeface::Style )) {
On 2015/06/09 14:39:49, mtklein wrote:
> Something like SetGlobalCreateFromNameDelegate?  Particularly keen to get Set
in
> there so it's clear There Can Be Only One, and Global to remind us it's, well,
> global.
> 
> Alternatively, if we want to make this a little more backdoor-y, less public,
we
> could just drop this function entirely, make the function pointer a non-static
> global, and have DM declare and set it manually?

Renamed as recommended. I have no opinion about whether to make it more
back-door.

https://codereview.chromium.org/1163283002/diff/100001/include/core/SkTypefac...
include/core/SkTypeface.h:419: static SkTypeface* (*fCreateDelegate)(const char
name[], SkTypeface::Style style);
On 2015/06/09 14:47:51, bungeman1 wrote:
> We often have a typedef (and end it with Proc) to make things a bit shorter so
> maybe have a
> 
> using NameDelegateProc = SkTypeface* (*)(const char name[], SkTypeface::Style
> style);
> 
> We're already using this type in three places, so it would be nice to have a
> name so we're not repeating.

Done.

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
File tools/sk_tool_utils_font.cpp (right):

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
tools/sk_tool_utils_font.cpp:50: SkDebugf("missing %s %d\n", name, style);
On 2015/06/09 14:39:49, mtklein wrote:
> Should we consider just crashing here instead?

Let's defer the crash until after old tests have been converted.

https://codereview.chromium.org/1163283002/diff/100001/tools/sk_tool_utils_fo...
tools/sk_tool_utils_font.cpp:51: SkAutoTUnref<SkFontMgr>
fm(SkFontMgr::RefDefault());
On 2015/06/09 14:39:48, mtklein wrote:
> Is this something like
> 
> // If we called SkTypeface::CreateFromName() here we'd recurse infinitely,
> // so we reimplement its core logic here inline without the recursive aspect.
> 
> ?

Done.

[caryclark, 2015-06-09 16:37:58]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 16:38:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/110001

[commit-bot: I haz the power, 2015-06-09 16:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 16:45:26]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-06-09 16:46:11]

The code change itself lgtm.

[mtklein, 2015-06-09 17:04:15]

lgtm too

https://codereview.chromium.org/1163283002/diff/110001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1163283002/diff/110001/dm/DM.cpp#newcode717
dm/DM.cpp:717: return sk_tool_utils::create_portable_typeface_always(familyName,
style);
Whacky indent here?

[caryclark, 2015-06-09 17:10:42]

https://codereview.chromium.org/1163283002/diff/110001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1163283002/diff/110001/dm/DM.cpp#newcode717
dm/DM.cpp:717: return sk_tool_utils::create_portable_typeface_always(familyName,
style);
On 2015/06/09 17:04:15, mtklein wrote:
> Whacky indent here?

Done.

[caryclark, 2015-06-09 20:13:12]

Mike, since this change has evolved to edit include/SkTypeface.h, you'll need to
lgtm -- or if you prefer mtklein's backdoor approach, I'll do that instead.

[reed1, 2015-06-09 20:17:26]

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypefac...
include/core/SkTypeface.h:326: static void
SetGlobalCreateFromNameDelegate(CreateFromNameDelegateProc delegate) {
add even 1-liner dox?

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypefac...
include/core/SkTypeface.h:421: static CreateFromNameDelegateProc
fCreateDelegate;
nit: gGlobals start with 'g'

https://codereview.chromium.org/1163283002/diff/120001/src/core/SkTypeface.cpp
File src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/1163283002/diff/120001/src/core/SkTypeface.cp...
src/core/SkTypeface.cpp:116: return (*fCreateDelegate)(name, style);
Perhaps we should check if the proxy returns NULL, and then fall-through to
normal code?

[caryclark, 2015-06-10 11:50:21]

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypefac...
include/core/SkTypeface.h:326: static void
SetGlobalCreateFromNameDelegate(CreateFromNameDelegateProc delegate) {
On 2015/06/09 20:17:26, reed1 wrote:
> add even 1-liner dox?

removed from public interface instead

https://codereview.chromium.org/1163283002/diff/120001/include/core/SkTypefac...
include/core/SkTypeface.h:421: static CreateFromNameDelegateProc
fCreateDelegate;
On 2015/06/09 20:17:26, reed1 wrote:
> nit: gGlobals start with 'g'

Done.

https://codereview.chromium.org/1163283002/diff/120001/src/core/SkTypeface.cpp
File src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/1163283002/diff/120001/src/core/SkTypeface.cp...
src/core/SkTypeface.cpp:116: return (*fCreateDelegate)(name, style);
On 2015/06/09 20:17:26, reed1 wrote:
> Perhaps we should check if the proxy returns NULL, and then fall-through to
> normal code?

Done.

[caryclark, 2015-06-10 11:50:41]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[caryclark, 2015-06-10 11:50:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1163283002/#ps130001
(title: "remove duplicate code")

[commit-bot: I haz the power, 2015-06-10 11:50:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/130001

[commit-bot: I haz the power, 2015-06-10 11:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 11:56:15]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-06-10 16:25:13]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-06-10 16:25:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1163283002/#ps140001
(title: "rewrite aaxfermodes.cpp to reduce test area")

[commit-bot: I haz the power, 2015-06-10 16:25:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163283002/140001

[commit-bot: I haz the power, 2015-06-10 16:31:13]

Committed patchset #15 (id:140001) as
https://skia.googlesource.com/skia/+/83ca628cb6c959524edc3a696d7c3b5f7f1826ba