Issue 1163273002: Oilpan: Make WebSocketChannel GarbageCollectedFinalized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163273002: Oilpan: Make WebSocketChannel GarbageCollectedFinalized (Closed)

Created:
4 years, 10 months ago by haraken

Modified:
4 years, 10 months ago

Reviewers:
oilpan-reviews, tyoshino (SeeGerritForStatus), yhirano

CC:
blink-reviews, yhirano+watch_chromium.org, tyoshino+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Make WebSocketChannel GarbageCollectedFinalized Now that WebSocketChannel::ref/deref is gone, WebSocketChannel doesn't need to be RefCountedGarbageCollected. This CL changes WebSocketChannel to GarbageCollectedFinalized. BUG=497595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196651

Patch Set 1 #

Patch Set 2 : #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	Source/modules/websockets/WebSocketChannel.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163273002/20001

4 years, 10 months ago (2015-06-08 05:19:06 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-08 06:18:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196651

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages