Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1163253003: Clean up macros around DEFINE_EVENT_TARGET_REFCOUNTING (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews, serviceworker-reviews, tzik, eae+blinkwatch, eric.carlson_apple.com, apavlov+blink_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, yhirano+watch_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, kenneth.christiansen, sof, philipj_slow, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, timvolodine, darktears, jsbell+idb_chromium.org, michaeln, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, horo+watch_chromium.org, falken, kinuko+serviceworker, cmumford, dgrogan, peter+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up macros around DEFINE_EVENT_TARGET_REFCOUNTING The current macros are messy. This CL changes the macros as follows (which is more consistent and easy to understand): - If the EventTarget class is RefCounted on non-oilpan builds, use REFCOUNTED_EVENT_TARGET. - If the EventTarget class is RefCountedGarbageCollected on non-oilpan builds, use REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET. BUG=497595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196663

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M Source/core/css/FontFaceSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 1 3 chunks +9 lines, -12 lines 0 comments Download
M Source/core/fileapi/FileReader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/battery/BatteryManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/netinfo/NetworkInformation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/permissions/PermissionStatus.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/Presentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/PresentationSession.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/DOMWebSocket.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
PTAL
4 years, 10 months ago (2015-06-08 07:48:12 UTC) #2
keishi
LGTM
4 years, 10 months ago (2015-06-08 09:00:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163253003/20001
4 years, 10 months ago (2015-06-08 09:02:16 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 10:24:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196663

Powered by Google App Engine
This is Rietveld 408576698