Issue 1163223003: DevTools: better error handling in paint profiler UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163223003: DevTools: better error handling in paint profiler UI (Closed)

Created:
4 years, 11 months ago by caseq

Modified:
4 years, 10 months ago

Reviewers:
yurys, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: better error handling in paint profiler UI Avoid exception when displaying an empty paint command list. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196664

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	Source/devtools/front_end/layers/LayerPaintProfilerView.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/PaintProfilerView.js	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePaintProfilerView.js	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/ui_lazy/OverviewGrid.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163223003/1

4 years, 10 months ago (2015-06-08 09:15:13 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-08 10:26:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196664

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages