DevTools: Show main thread as a stacked utilization chart on timeline overview.

DevTools: Show main thread as a stacked utilization chart on timeline overview.

BUG=497166
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196757

[alph, 2015-06-05 15:44:08]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org, yurys@chromium.org

[yurys, 2015-06-09 09:19:26]

lgtm

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:210: var idleIndex =
categoryOrder.indexOf("idle");
idleIndex = 0 and assert?

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:213:
categories[categoryOrder[i]]._overviewIndex = i;
Consider doing this once in the categories initializer.

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:239: var index =
indexStack.length ? indexStack.peekLast() : idleIndex;
categoryIndexStack?

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:487: this._remainder
+= interval;
_remainder -> _elapsed or _utilized ? Or better make it actually remainder.

[alph, 2015-06-09 09:47:24]

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:210: var idleIndex =
categoryOrder.indexOf("idle");
On 2015/06/09 09:19:26, yurys wrote:
> idleIndex = 0 and assert?

Done.

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:213:
categories[categoryOrder[i]]._overviewIndex = i;
On 2015/06/09 09:19:26, yurys wrote:
> Consider doing this once in the categories initializer.

The index is specific to this function, so I want to keep it in one place.

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:239: var index =
indexStack.length ? indexStack.peekLast() : idleIndex;
On 2015/06/09 09:19:26, yurys wrote:
> categoryIndexStack?

Done.

https://codereview.chromium.org/1163223002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:487: this._remainder
+= interval;
On 2015/06/09 09:19:26, yurys wrote:
> _remainder -> _elapsed or _utilized ? Or better make it actually remainder.

Done.

[yurys, 2015-06-09 09:57:21]

still lgtm % the comment below

https://codereview.chromium.org/1163223002/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1163223002/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/timeline/TimelineEventOverview.js:486: if (interval <=
this._remainder) {
It may happen that the last interval won't be drawn, is that intentional?

[alph, 2015-06-09 10:36:32]

https://codereview.chromium.org/1163223002/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1163223002/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/timeline/TimelineEventOverview.js:486: if (interval <=
this._remainder) {
On 2015/06/09 09:57:20, yurys wrote:
> It may happen that the last interval won't be drawn, is that intentional?

Done.

[alph, 2015-06-09 10:36:54]

The CQ bit was checked by alph@chromium.org

[alph, 2015-06-09 10:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1163223002/#ps40001
(title: "for landing")

[commit-bot: I haz the power, 2015-06-09 10:37:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163223002/40001

[commit-bot: I haz the power, 2015-06-09 11:46:30]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196757