Issue 1163163003: Call isStyledElement() only once in Element::attributeChanged()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163163003: Call isStyledElement() only once in Element::attributeChanged() (Closed)

Created:
4 years, 11 months ago by Mikhail

Modified:
4 years, 11 months ago

Reviewers:
sof, Mike West

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Call isStyledElement() only once in Element::attributeChanged() This patch removes an unneeded extra call of isStyledElement() from the Element::attributeChanged() method. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196559

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	Source/core/dom/Element.cpp	View		1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163163003/1

4 years, 11 months ago (2015-06-05 06:47:29 UTC) #6

commit-bot: I haz the power

4 years, 11 months ago (2015-06-05 06:50:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196559

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages