Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1163073002: Replace ad-hoc weakness in prototype transitions with WeakCell. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace ad-hoc weakness in prototype transitions with WeakCell. BUG= Committed: https://crrev.com/bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3 Cr-Commit-Position: refs/heads/master@{#28830}

Patch Set 1 #

Patch Set 2 : Fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/transitions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/transitions.cc View 1 5 chunks +18 lines, -13 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ulan
ptal
5 years, 6 months ago (2015-06-03 14:11:18 UTC) #2
Hannes Payer (out of office)
cool! lgtm
5 years, 6 months ago (2015-06-03 18:04:41 UTC) #3
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-08 08:51:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163073002/20001
5 years, 6 months ago (2015-06-08 10:01:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 10:20:39 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3 Cr-Commit-Position: refs/heads/master@{#28830}
5 years, 6 months ago (2015-06-08 10:21:00 UTC) #9
ulan
5 years, 6 months ago (2015-06-08 11:20:04 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1169733002/ by ulan@chromium.org.

The reason for reverting is: GC stress failures..

Powered by Google App Engine
This is Rietveld 408576698