Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1163023002: [AppRemoting] Implements LicenseManager. (Closed)

Created:
5 years, 6 months ago by kelvinp
Modified:
5 years, 6 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org, Sriram
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AppRemoting] Implements LicenseManager. This CL defines the LicenseManager interface and implements a dummy GaiaLicenseManager that returns the user's Gaia token. BUG=b/19799333 Committed: https://crrev.com/d798099e961f5b201834738495366dba2f1ffdfc Cr-Commit-Position: refs/heads/master@{#333645}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Reviewer's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -10 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting.js View 1 2 chunks +18 lines, -9 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 3 chunks +7 lines, -1 line 0 comments Download
A remoting/webapp/app_remoting/js/gaia_license_manager.js View 1 chunk +38 lines, -0 lines 0 comments Download
A remoting/webapp/app_remoting/js/license_manager.js View 1 chunk +47 lines, -0 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kelvinp
PTAL https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/license_manager.js File remoting/webapp/app_remoting/js/license_manager.js (right): https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/license_manager.js#newcode15 remoting/webapp/app_remoting/js/license_manager.js:15: remoting.LicenseManager = function() {}; I renamed AppRemotingAuth to ...
5 years, 6 months ago (2015-06-02 21:18:08 UTC) #2
kelvinp
Ping
5 years, 6 months ago (2015-06-04 18:07:14 UTC) #3
garykac
https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (right): https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js#newcode73 remoting/webapp/app_remoting/js/app_remoting.js:73: this.licenseManager_.getSubscriptionToken(token).then( We should allow licenseManager go be null and ...
5 years, 6 months ago (2015-06-04 22:13:43 UTC) #4
kelvinp
PTAL https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (right): https://codereview.chromium.org/1163023002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js#newcode73 remoting/webapp/app_remoting/js/app_remoting.js:73: this.licenseManager_.getSubscriptionToken(token).then( On 2015/06/04 22:13:43, garykac wrote: > We ...
5 years, 6 months ago (2015-06-05 20:45:20 UTC) #5
garykac
lgtm
5 years, 6 months ago (2015-06-09 23:22:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163023002/20001
5 years, 6 months ago (2015-06-10 00:20:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 01:57:41 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 01:58:34 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d798099e961f5b201834738495366dba2f1ffdfc
Cr-Commit-Position: refs/heads/master@{#333645}

Powered by Google App Engine
This is Rietveld 408576698