DevTools: rename debugger/ to devtools/, move DevTools files into content/renderer/devtools.

DevTools: rename debugger/ to devtools/, move DevTools files into content/renderer/devtools.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173891

[pfeldman, 2012-12-18 15:36:34]

John, this change renames /debugger/ folders into /devtools/. I can't make it
apply due to git cl generating weird diffs. Do you know what is wrong? (I happen
to change the files I move).

[jam, 2012-12-18 17:58:45]

lgtm

On 2012/12/18 15:36:34, pfeldman wrote:
> John, this change renames /debugger/ folders into /devtools/. I can't make it
> apply due to git cl generating weird diffs. Do you know what is wrong? (I
happen
> to change the files I move).

I don't use git, so I don't know. This stuff works fine for me using svn. but I
doubt you want to redo the change locally :) if it compiles for you locally, I'd
just land it and fix any breakages on the tree.

[tfarina, 2012-12-18 18:28:36]

On Tue, Dec 18, 2012 at 3:58 PM,  <jam@chromium.org> wrote:
> lgtm
>
>
> On 2012/12/18 15:36:34, pfeldman wrote:
>>
>> John, this change renames /debugger/ folders into /devtools/. I can't make
>> it
>> apply due to git cl generating weird diffs. Do you know what is wrong? (I
>
> happen
>>
>> to change the files I move).
>
>
> I don't use git, so I don't know. This stuff works fine for me using svn.
> but I
> doubt you want to redo the change locally :) if it compiles for you locally,
> I'd
> just land it and fix any breakages on the tree.
>
If you land manually you are going to lose the history. You should
land this through CQ.

If you are doing everything right, it should apply fine on rietveld.

> https://codereview.chromium.org/11630004/



-- 
Thiago

[pfeldman, 2012-12-18 18:33:47]

> If you land manually you are going to lose the history. You should
> land this through CQ.
> 

Could you define "manually"? I think git cl dcommit as well as git svn dcommit
would maintain renames. I am not sure why I would lose the history.

> If you are doing everything right, it should apply fine on rietveld.
> 

Well, I don't do anything. My git generates proper diff and my git cl upload
generates malformed diff. You can see it attached above.

[M-A Ruel, 2012-12-18 18:36:27]

On 2012/12/18 18:33:47, pfeldman wrote:
> > If you land manually you are going to lose the history. You should
> > land this through CQ.
> > 
> 
> Could you define "manually"? I think git cl dcommit as well as git svn dcommit
> would maintain renames. I am not sure why I would lose the history.
> 
> > If you are doing everything right, it should apply fine on rietveld.
> > 
> 
> Well, I don't do anything. My git generates proper diff and my git cl upload
> generates malformed diff. You can see it attached above.

git cl help upload
You can adjust --similarity

[tfarina, 2012-12-18 18:46:32]

On Tue, Dec 18, 2012 at 4:33 PM,  <pfeldman@chromium.org> wrote:
> Could you define "manually"? I think git cl dcommit as well as git svn
> dcommit
> would maintain renames. I am not sure why I would lose the history.
>
I don't know the ins and outs, maruel does. But it loses.

>> If you are doing everything right, it should apply fine on rietveld.
>
> Well, I don't do anything. My git generates proper diff and my git cl upload
> generates malformed diff. You can see it attached above.
>
Adjusting the similarity should make it work properly.

> https://codereview.chromium.org/11630004/

-- 
Thiago

[pfeldman, 2012-12-18 18:49:57]

> git cl help upload
> You can adjust --similarity

I even tried --no-find-copies and it did not help. Or is it something different?

[joth, 2012-12-18 18:54:50]

lgtm for aw/

[M-A Ruel, 2012-12-18 19:09:46]

+Robert for git cl upload diff format.

[iannucci, 2012-12-18 19:41:50]

On 2012/12/18 19:09:46, Marc-Antoine Ruel wrote:
> +Robert for git cl upload diff format.

This patch looks OK to me. SVN implements a file move (with history) as an A+
with a D, which is what this patch is doing.  It would be an issue if the patch
was showing A with a D, because then the history wouldn't carry over.

[iannucci, 2012-12-18 19:48:19]

On 2012/12/18 19:41:50, iannucci wrote:
> On 2012/12/18 19:09:46, Marc-Antoine Ruel wrote:
> > +Robert for git cl upload diff format.
> 
> This patch looks OK to me. SVN implements a file move (with history) as an A+
> with a D, which is what this patch is doing.  It would be an issue if the
patch
> was showing A with a D, because then the history wouldn't carry over.

(Though it does look like a rebase may be necessary)