Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162993005: Renamed google.protobuf to protobuf26 (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comment #

Patch Set 3 : Addressed comments #

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -10363 lines) Patch
M commit_queue.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 2 1 chunk +14 lines, -5 lines 0 comments Download
D third_party/google/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/google/protobuf/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/google/protobuf/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/google/protobuf/compiler/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/google/protobuf/compiler/plugin_pb2.py View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/google/protobuf/descriptor.py View 1 chunk +0 lines, -849 lines 0 comments Download
D third_party/google/protobuf/descriptor_database.py View 1 chunk +0 lines, -137 lines 0 comments Download
D third_party/google/protobuf/descriptor_pb2.py View 1 chunk +0 lines, -1522 lines 0 comments Download
D third_party/google/protobuf/descriptor_pool.py View 1 chunk +0 lines, -643 lines 0 comments Download
D third_party/google/protobuf/internal/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/google/protobuf/internal/api_implementation.py View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/google/protobuf/internal/containers.py View 1 chunk +0 lines, -269 lines 0 comments Download
D third_party/google/protobuf/internal/cpp_message.py View 1 chunk +0 lines, -663 lines 0 comments Download
D third_party/google/protobuf/internal/decoder.py View 1 chunk +0 lines, -831 lines 0 comments Download
D third_party/google/protobuf/internal/encoder.py View 1 chunk +0 lines, -788 lines 0 comments Download
D third_party/google/protobuf/internal/enum_type_wrapper.py View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/google/protobuf/internal/message_listener.py View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/google/protobuf/internal/python_message.py View 1 chunk +0 lines, -1247 lines 0 comments Download
D third_party/google/protobuf/internal/type_checkers.py View 1 chunk +0 lines, -328 lines 0 comments Download
D third_party/google/protobuf/internal/wire_format.py View 1 chunk +0 lines, -268 lines 0 comments Download
D third_party/google/protobuf/message.py View 1 chunk +0 lines, -284 lines 0 comments Download
D third_party/google/protobuf/message_factory.py View 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/google/protobuf/reflection.py View 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/google/protobuf/service.py View 1 chunk +0 lines, -226 lines 0 comments Download
D third_party/google/protobuf/service_reflection.py View 1 chunk +0 lines, -284 lines 0 comments Download
D third_party/google/protobuf/symbol_database.py View 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/google/protobuf/text_encoding.py View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/google/protobuf/text_format.py View 1 chunk +0 lines, -873 lines 0 comments Download
A third_party/protobuf26/README.chromium View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/protobuf26/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/compiler/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/compiler/plugin_pb2.py View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/protobuf26/descriptor.py View 4 chunks +5 lines, -5 lines 0 comments Download
A + third_party/protobuf26/descriptor_database.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/descriptor_pb2.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/protobuf26/descriptor_pool.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/protobuf26/internal/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/internal/api_implementation.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/protobuf26/internal/containers.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/internal/cpp_message.py View 6 chunks +8 lines, -8 lines 0 comments Download
A + third_party/protobuf26/internal/decoder.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/protobuf26/internal/encoder.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/protobuf26/internal/enum_type_wrapper.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/internal/message_listener.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/internal/python_message.py View 1 chunk +10 lines, -10 lines 0 comments Download
A + third_party/protobuf26/internal/type_checkers.py View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/protobuf26/internal/wire_format.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/protobuf26/message.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/message_factory.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/protobuf26/reflection.py View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/protobuf26/service.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/service_reflection.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/symbol_database.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/protobuf26/text_encoding.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/protobuf26/text_format.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-03 17:45:46 UTC) #1
pgervais
Some suggestions for documentation. Otherwise looks good. https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py File third_party/cq_client/cq_pb2.py (right): https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py#newcode4 third_party/cq_client/cq_pb2.py:4: # changes ...
5 years, 6 months ago (2015-06-03 17:51:34 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py File third_party/cq_client/cq_pb2.py (right): https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py#newcode4 third_party/cq_client/cq_pb2.py:4: # changes again and add this comment back. More ...
5 years, 6 months ago (2015-06-03 18:00:32 UTC) #3
pgervais
On 2015/06/03 18:00:32, Sergiy Byelozyorov wrote: > https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py > File third_party/cq_client/cq_pb2.py (right): > > https://codereview.chromium.org/1162993005/diff/1/third_party/cq_client/cq_pb2.py#newcode4 ...
5 years, 6 months ago (2015-06-03 18:06:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162993005/60001
5 years, 6 months ago (2015-06-03 18:08:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 18:12:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295512

Powered by Google App Engine
This is Rietveld 408576698