Stop including ip_address_number.h from net_util.h

Stop including ip_address_number.h from net_util.h

Required duplicating the typedef for IPAddressNumber, and fixing a number of missing includes from consumers.

BUG=488531
TBR=jam@chromium.org,rpaquay@chromium.org,keybuk@chromium.org,

Committed: https://crrev.com/c9a6b72a7a6a5b3764e829c5fe74de4aa67e9fe3
Cr-Commit-Position: refs/heads/master@{#332708}

[eroman, 2015-06-03 01:41:11]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[eroman, 2015-06-03 01:41:12]

much fun to be had here...

[mmenke, 2015-06-03 15:21:25]

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h
File net/base/net_util.h (right):

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h#ne...
net/base/net_util.h:8: 
nit:  Remove extra blank line

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h#ne...
net/base/net_util.h:36: typedef std::vector<unsigned char> IPAddressNumber;
Hrm...  I'm very skeptical of keeping this here.  After your other CL lands, the
only function in this file that even uses this is GetAddressFamily.

[eroman, 2015-06-03 16:23:28]

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h
File net/base/net_util.h (right):

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h#ne...
net/base/net_util.h:36: typedef std::vector<unsigned char> IPAddressNumber;
On 2015/06/03 15:21:25, mmenke wrote:
> Hrm...  I'm very skeptical of keeping this here.  After your other CL lands,
the
> only function in this file that even uses this is GetAddressFamily.

I could perhaps move GetAddressFamily() elsewhere. But in the meantime I don't
want to prevent regressions since tracking down all the headers was really
annoying.

[mmenke, 2015-06-03 17:23:11]

LGTM (Note that I did not do an exhaustive review of the reason for every header
change)

https://codereview.chromium.org/1162973005/diff/160001/net/dns/dns_hosts.h
File net/dns/dns_hosts.h (right):

https://codereview.chromium.org/1162973005/diff/160001/net/dns/dns_hosts.h#ne...
net/dns/dns_hosts.h:17: #include "net/base/ip_address_number.h"  // can't
forward-declare IPAddressNumber
I think we can just remove the comment here

[mmenke, 2015-06-03 17:24:53]

On 2015/06/03 16:23:28, eroman wrote:
> https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h
> File net/base/net_util.h (right):
> 
>
https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h#ne...
> net/base/net_util.h:36: typedef std::vector<unsigned char> IPAddressNumber;
> On 2015/06/03 15:21:25, mmenke wrote:
> > Hrm...  I'm very skeptical of keeping this here.  After your other CL lands,
> the
> > only function in this file that even uses this is GetAddressFamily.
> 
> I could perhaps move GetAddressFamily() elsewhere. But in the meantime I don't
> want to prevent regressions since tracking down all the headers was really
> annoying.

Oops...forgot to response to this.  If it's a temporary thing, I'm fine with it.
 Longer term, I'm less convinced.  Suppose could just move GetAddressFamily into
ip_address_number.h, though then ip_address_number.h would have to include
net_util....

[eroman, 2015-06-03 18:19:49]

Another possibility would be to change IPAddressNumber into an actual class
(which just contains a std::vector).

Then we could forward declare as normal, and many of the existing helpers would
make sense as instance methods

[mmenke, 2015-06-03 18:20:20]

On 2015/06/03 18:19:49, eroman wrote:
> Another possibility would be to change IPAddressNumber into an actual class
> (which just contains a std::vector).
> 
> Then we could forward declare as normal, and many of the existing helpers
would
> make sense as instance methods

I'd certainly be fine with that.

[eroman, 2015-06-03 18:29:10]

I will keep the duplicated typedef for now, and re-visit this later (since I
think the duplication is still less evil than including all the unnecessary
headers).

I filed https://code.google.com/p/chromium/issues/detail?id=496258 as one
possibility to tackle this

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h
File net/base/net_util.h (right):

https://codereview.chromium.org/1162973005/diff/160001/net/base/net_util.h#ne...
net/base/net_util.h:8: 
On 2015/06/03 15:21:25, mmenke wrote:
> nit:  Remove extra blank line

Done.

https://codereview.chromium.org/1162973005/diff/160001/net/dns/dns_hosts.h
File net/dns/dns_hosts.h (right):

https://codereview.chromium.org/1162973005/diff/160001/net/dns/dns_hosts.h#ne...
net/dns/dns_hosts.h:17: #include "net/base/ip_address_number.h"  // can't
forward-declare IPAddressNumber
On 2015/06/03 17:23:10, mmenke wrote:
> I think we can just remove the comment here

Done.

[eroman, 2015-06-03 18:39:14]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2015-06-03 18:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1162973005/#ps200001
(title: "rebase onto master")

[commit-bot: I haz the power, 2015-06-03 18:39:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162973005/200001

[eroman, 2015-06-03 18:57:28]

eroman@chromium.org changed reviewers:
+ jam@chromium.org, keybuk@chromium.org, rpaquay@chromium.org

[eroman, 2015-06-03 18:57:29]

TBRing owners.

Details: This changelist is just adding the necessary #includes to keep things
compiling, after removing some headers from net_util.h. Include what you use in
other words.

keybuk:
  device/bluetooth/bluetooth_socket_chromeos.cc
  device/bluetooth/bluetooth_socket_win.cc
jam:
  chrome/browser/extensions/api/mdns/dns_sd_device_lister.cc
  chrome/browser/local_discovery/service_discovery_client_mac.mm
  chrome/browser/media/webrtc_logging_handler_host.cc
  chrome/browser/safe_browsing/safe_browsing_database.cc
  chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
  chrome/browser/services/gcm/gcm_account_tracker.cc
  chrome/renderer/media/cast_receiver_session_delegate.cc
  components/dom_distiller/core/distiller_unittest.cc
  components/dom_distiller/core/dom_distiller_service.cc
  components/dom_distiller/core/task_tracker.cc
  components/html_viewer/blink_platform_impl.cc
  content/browser/devtools/protocol/tethering_handler.cc
  content/child/blink_platform_impl.cc
  content/child/blink_platform_impl_unittest.cc
  content/renderer/p2p/host_address_request.h
  content/renderer/p2p/ipc_network_manager.cc
  content/renderer/p2p/ipc_network_manager_unittest.cc
  extensions/browser/api/cast_channel/cast_transport.h
  extensions/browser/api/cast_channel/logger.h
  extensions/browser/api/system_network/system_network_api.cc
  media/cast/net/cast_transport_sender_impl.h
  media/cast/net/rtcp/rtcp_unittest.cc
  media/cast/test/fake_media_source.cc
  mojo/services/network/http_connection_impl.cc
  remoting/host/gcd_rest_client.cc
  remoting/host/remoting_me2me_host.cc
  remoting/test/app_remoting_connected_client_fixture.h
rpaquay:
  device/bluetooth/bluetooth_socket_win.cc
  extensions/browser/api/system_network/system_network_api.cc

[commit-bot: I haz the power, 2015-06-03 19:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 19:27:29]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[eroman, 2015-06-03 19:55:15]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-06-03 19:55:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1162973005/#ps240001
(title: "account for the upstream change to network_interfaces")

[commit-bot: I haz the power, 2015-06-03 19:56:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162973005/240001

[commit-bot: I haz the power, 2015-06-03 20:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 20:52:09]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[eroman, 2015-06-03 22:11:06]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-06-03 22:11:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1162973005/#ps260001
(title: "remove some header sorting changes, seems to be breaking windows")

[commit-bot: I haz the power, 2015-06-03 22:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162973005/260001

[commit-bot: I haz the power, 2015-06-03 22:19:08]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-06-03 22:20:03]

Patchset 14 (id:??) landed as
https://crrev.com/c9a6b72a7a6a5b3764e829c5fe74de4aa67e9fe3
Cr-Commit-Position: refs/heads/master@{#332708}