Cleanup: Move PopupOpeningObserver ownership from ChromeClient to ChromeClientImpl.

Source/core/page/ChromeClient.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 137 matching lines @@
     virtual float clampPageScaleFactorToLimits(float scale) const { return scale; }
     virtual void layoutUpdated(LocalFrame*) const { }
 
     void mouseDidMoveOverElement(const HitTestResult&);
     virtual void setToolTip(const String&, TextDirection) = 0;
 
     void print(LocalFrame*);
 
     virtual void annotatedRegionsChanged() = 0;
 
-    PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&);
+    virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) = 0;
 
     // This function is used for:
     //  - Mandatory date/time choosers if !ENABLE(INPUT_MULTIPLE_FIELDS_UI)
     //  - Date/time choosers for types for which LayoutTheme::supportsCalendarPicker
     //    returns true, if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
     //  - <datalist> UI for date/time input types regardless of
     //    ENABLE(INPUT_MULTIPLE_FIELDS_UI)
-    PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&);
+    virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;
 
-    void openTextDataListChooser(HTMLInputElement&);
+    virtual void openTextDataListChooser(HTMLInputElement&)= 0;
 
-    void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>);
+    virtual void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) = 0;
 
     // Asychronous request to enumerate all files in a directory chosen by the user.
     virtual void enumerateChosenDirectory(FileChooser*) = 0;
 
     // Allows ports to customize the type of graphics layers created by this page.
     virtual GraphicsLayerFactory* graphicsLayerFactory() const { return nullptr; }
 
     // Pass 0 as the GraphicsLayer to detach the root layer.
     // This sets the graphics layer for the LocalFrame's WebWidget, if it has one. Otherwise
     // it sets it for the WebViewImpl.
     virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) = 0;
 
     virtual void attachCompositorAnimationTimeline(WebCompositorAnimationTimeline*, LocalFrame* localRoot) { }
     virtual void detachCompositorAnimationTimeline(WebCompositorAnimationTimeline*, LocalFrame* localRoot) { }
 
     virtual void enterFullScreenForElement(Element*) { }
     virtual void exitFullScreenForElement(Element*) { }
 
     virtual void clearCompositedSelection() { }
     virtual void updateCompositedSelection(const CompositedSelection&) { }
 
     virtual void needTouchEvents(bool) = 0;
 
     virtual void setTouchAction(TouchAction) = 0;
 
     // Checks if there is an opened popup, called by LayoutMenuList::showPopup().
     virtual bool hasOpenedPopup() const = 0;
-    PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*);
+    virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) = 0;
     virtual DOMWindow* pagePopupWindowForTesting() const = 0;
 
     virtual void postAccessibilityNotification(AXObject*, AXObjectCache::AXNotification) { }
     virtual String acceptLanguages() = 0;
 
     enum DialogType {
         AlertDialog = 0,
         ConfirmDialog = 1,
         PromptDialog = 2,
         HTMLDialog = 3
@@ skipping 21 matching lines @@
     virtual void willSetInputMethodState() { }
     virtual void didUpdateTextOfFocusedElementByNonUserInput() { }
     virtual void showImeIfNeeded() { }
 
     virtual void registerViewportLayers() const { }
 
     virtual void showUnhandledTapUIIfNeeded(IntPoint, Node*, bool) { }
 
     virtual void didUpdateTopControls() const { }
 
-    void registerPopupOpeningObserver(PopupOpeningObserver*);
-    void unregisterPopupOpeningObserver(PopupOpeningObserver*);
-    void notifyPopupOpeningObservers() const;
+    virtual void registerPopupOpeningObserver(PopupOpeningObserver*) = 0;
+    virtual void unregisterPopupOpeningObserver(PopupOpeningObserver*) = 0;
 
 protected:
     virtual ~ChromeClient() { }
 
     virtual void showMouseOverURL(const HitTestResult&) = 0;
     // TODO(tkent): Adding 'Internal' to virtual functions is not good. We
     // should give better names, or move out non-internal versions of these
     // functions.
     virtual void setWindowRectInternal(const IntRect&) = 0;
     virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0;
     virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0;
     virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0;
     virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0;
     virtual void printInternal(LocalFrame*) = 0;
-    virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(LocalFrame*, ColorChooserClient*, const Color&) = 0;
-    virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;
-    virtual void openTextDataListChooserInternal(HTMLInputElement&) = 0;
-    virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) = 0;
-    virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame&, PopupMenuClient*) = 0;
     virtual void setCursorInternal(const Cursor&) = 0;
 
 private:
     bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const String& message);
     void setToolTip(const HitTestResult&);
 
-    Vector<PopupOpeningObserver*> m_popupOpeningObservers;
     Cursor m_lastSetMouseCursorForTesting;
 };
 
 } // namespace blink
 
 #endif // ChromeClient_h