Cleanup: Move PopupOpeningObserver ownership from ChromeClient to ChromeClientImpl.

Cleanup: Move PopupOpeningObserver ownership from ChromeClient to ChromeClientImpl.

ChromeClient implementations other than ChromeClientImpl don't need this
functionality because they don't open popups.  We can move
notifyPopupOpeningObservers() calls to ChromeClientImpl, and eliminate
ChromeClient::foo/fooInternal separations for popup-related functions.

BUG=495378
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196361

[tkent, 2015-06-02 08:13:30]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2015-06-02 08:13:30]

yosin@, please review this.

[tkent, 2015-06-02 12:43:19]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2015-06-03 01:03:42]

lgtm w/ Q

https://codereview.chromium.org/1162953002/diff/20001/Source/web/ChromeClient...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1162953002/diff/20001/Source/web/ChromeClient...
Source/web/ChromeClientImpl.cpp:957: for (size_t i = 0; i < observers.size();
++i)
Can we use range-for?
It seems there are some of them:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[tkent, 2015-06-03 01:21:01]

https://codereview.chromium.org/1162953002/diff/20001/Source/web/ChromeClient...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1162953002/diff/20001/Source/web/ChromeClient...
Source/web/ChromeClientImpl.cpp:957: for (size_t i = 0; i < observers.size();
++i)
On 2015/06/03 01:03:42, Yosi_UTC9 wrote:
> Can we use range-for?
> It seems there are some of them:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Yes, we can.  I'll make a general style fix CL later.

[tkent, 2015-06-03 01:21:06]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-06-03 01:22:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162953002/20001

[commit-bot: I haz the power, 2015-06-03 01:26:28]

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196361