Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1162943008: Make aapt and aidl paths flexible. (Closed)

Created:
5 years, 6 months ago by aurimas (slooooooooow)
Modified:
5 years, 6 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make aapt and aidl paths flexible. Android-M sdk moved these build-tools to a different directory and so we need to be able to set them in GYP_DEFINES for M sdk builds. BUG=None Committed: https://crrev.com/2a145dab21f4db16cca74c3f2d89fe911cc582b1 Cr-Commit-Position: refs/heads/master@{#332959}

Patch Set 1 #

Patch Set 2 : Define aapt_path in one location #

Patch Set 3 : move aapt_path definition #

Patch Set 4 : Fix GN builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M build/android/gyp/package_resources.py View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/process_resources.py View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/package_resources_action.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M build/java.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/java_aidl.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
aurimas (slooooooooow)
PTAL
5 years, 6 months ago (2015-06-04 19:12:36 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-04 21:13:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162943008/60001
5 years, 6 months ago (2015-06-04 21:25:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94862)
5 years, 6 months ago (2015-06-04 21:50:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162943008/60001
5 years, 6 months ago (2015-06-04 23:08:05 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-04 23:28:35 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 23:29:42 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2a145dab21f4db16cca74c3f2d89fe911cc582b1
Cr-Commit-Position: refs/heads/master@{#332959}

Powered by Google App Engine
This is Rietveld 408576698