Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1162943002: Replace more ObserverList with base::ObserverList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@observer
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 739
740 // Coordinate conversion ----------------------------------------------------- 740 // Coordinate conversion -----------------------------------------------------
741 741
742 gfx::RectF ClientRectToPhysicalWindowRect(const gfx::RectF& rect) const; 742 gfx::RectF ClientRectToPhysicalWindowRect(const gfx::RectF& rect) const;
743 743
744 // RenderFrameImpl accessible state ------------------------------------------ 744 // RenderFrameImpl accessible state ------------------------------------------
745 // The following section is the set of methods that RenderFrameImpl needs 745 // The following section is the set of methods that RenderFrameImpl needs
746 // to access RenderViewImpl state. The set of state variables are page-level 746 // to access RenderViewImpl state. The set of state variables are page-level
747 // specific, so they don't belong in RenderFrameImpl and should remain in 747 // specific, so they don't belong in RenderFrameImpl and should remain in
748 // this object. 748 // this object.
749 ObserverList<RenderViewObserver>& observers() { 749 base::ObserverList<RenderViewObserver>& observers() { return observers_; }
750 return observers_;
751 }
752 750
753 // TODO(nasko): Remove this method when we move to frame proxy objects, since 751 // TODO(nasko): Remove this method when we move to frame proxy objects, since
754 // the concept of swapped out will be eliminated. 752 // the concept of swapped out will be eliminated.
755 void set_is_swapped_out(bool swapped_out) { 753 void set_is_swapped_out(bool swapped_out) {
756 is_swapped_out_ = swapped_out; 754 is_swapped_out_ = swapped_out;
757 } 755 }
758 756
759 NavigationGesture navigation_gesture() { 757 NavigationGesture navigation_gesture() {
760 return navigation_gesture_; 758 return navigation_gesture_;
761 } 759 }
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 // is passed to us upon creation. WebKit asks for this ID upon first use and 985 // is passed to us upon creation. WebKit asks for this ID upon first use and
988 // uses it whenever asking the browser process to allocate new storage areas. 986 // uses it whenever asking the browser process to allocate new storage areas.
989 int64 session_storage_namespace_id_; 987 int64 session_storage_namespace_id_;
990 988
991 // Stores edit commands associated to the next key event. 989 // Stores edit commands associated to the next key event.
992 // Shall be cleared as soon as the next key event is processed. 990 // Shall be cleared as soon as the next key event is processed.
993 EditCommands edit_commands_; 991 EditCommands edit_commands_;
994 992
995 // All the registered observers. We expect this list to be small, so vector 993 // All the registered observers. We expect this list to be small, so vector
996 // is fine. 994 // is fine.
997 ObserverList<RenderViewObserver> observers_; 995 base::ObserverList<RenderViewObserver> observers_;
998 996
999 // Wraps the |webwidget_| as a MouseLockDispatcher::LockTarget interface. 997 // Wraps the |webwidget_| as a MouseLockDispatcher::LockTarget interface.
1000 scoped_ptr<MouseLockDispatcher::LockTarget> webwidget_mouse_lock_target_; 998 scoped_ptr<MouseLockDispatcher::LockTarget> webwidget_mouse_lock_target_;
1001 999
1002 // This field stores drag/drop related info for the event that is currently 1000 // This field stores drag/drop related info for the event that is currently
1003 // being handled. If the current event results in starting a drag/drop 1001 // being handled. If the current event results in starting a drag/drop
1004 // session, this info is sent to the browser along with other drag/drop info. 1002 // session, this info is sent to the browser along with other drag/drop info.
1005 DragEventSourceInfo possible_drag_event_info_; 1003 DragEventSourceInfo possible_drag_event_info_;
1006 1004
1007 // NOTE: stats_collection_observer_ should be the last members because their 1005 // NOTE: stats_collection_observer_ should be the last members because their
(...skipping 13 matching lines...) Expand all
1021 // use the Observer interface to filter IPC messages and receive frame change 1019 // use the Observer interface to filter IPC messages and receive frame change
1022 // notifications. 1020 // notifications.
1023 // --------------------------------------------------------------------------- 1021 // ---------------------------------------------------------------------------
1024 1022
1025 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1023 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1026 }; 1024 };
1027 1025
1028 } // namespace content 1026 } // namespace content
1029 1027
1030 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1028 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698