Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1162933003: Remove [TreatNullAs=NullString] from Document.domain (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove [TreatNullAs=NullString] from Document.domain Even before this change, setting document.domain=null would fail, but because it was treated as an empty string, where now it is "null". BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M LayoutTests/http/tests/security/document-domain-invalid.html View 2 chunks +19 lines, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162933003/1
5 years, 6 months ago (2015-06-05 20:01:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 21:48:29 UTC) #4
philipj_slow
PTAL
5 years, 6 months ago (2015-06-05 21:48:31 UTC) #6
Mike West
LGTM.
5 years, 6 months ago (2015-06-07 13:46:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162933003/1
5 years, 6 months ago (2015-06-07 19:11:05 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-07 20:34:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196635

Powered by Google App Engine
This is Rietveld 408576698