Issue 1162923004: Move the logic to set up a local origin for shell run to shell_arguments.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162923004: Move the logic to set up a local origin for shell run to shell_arguments.py. (Closed)

Created:
5 years, 6 months ago by ppi

Modified:
5 years, 6 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move the logic to set up a local origin for shell run to shell_arguments.py. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a60b274cc3958919f643be5852092ddefb6c0e35

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -18 lines)			Patch
M	mojo/devtools/common/devtoolslib/android_shell.py	View	1	3 chunks	+5 lines, -14 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/shell_arguments.py	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	mojo/tools/android_mojo_shell.py	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	mojo/tools/apptest_runner.py	View		3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 6 months ago (2015-06-03 12:17:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
a60b274cc3958919f643be5852092ddefb6c0e35 (presubmit successful).

Expand Messages | Collapse Messages