Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1162903006: [turbofan] Turn JSContextSpecializer into an AdvancedReducer. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn JSContextSpecializer into an AdvancedReducer. This in turn allows usage of AdvancedReducer::ReplaceWithValue which has access to the underlying graph reducer. R=titzer@chromium.org Committed: https://crrev.com/ed13ea1e3227dc5b44404d54866aee466780c100 Cr-Commit-Position: refs/heads/master@{#28838}

Patch Set 1 #

Patch Set 2 : Mark slow test on ARM64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M src/compiler/js-context-specialization.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 12 chunks +15 lines, -12 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-05 16:47:34 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-08 08:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162903006/1
5 years, 6 months ago (2015-06-08 08:16:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/6392)
5 years, 6 months ago (2015-06-08 09:17:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162903006/20001
5 years, 6 months ago (2015-06-08 12:07:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 12:10:10 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 12:10:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed13ea1e3227dc5b44404d54866aee466780c100
Cr-Commit-Position: refs/heads/master@{#28838}

Powered by Google App Engine
This is Rietveld 408576698