Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: Source/platform/exported/WebFederatedCredential.cpp

Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/exported/WebFederatedCredential.cpp
diff --git a/Source/platform/exported/WebFederatedCredential.cpp b/Source/platform/exported/WebFederatedCredential.cpp
index 64bb21dfc49b79904aae6433b3ddb5e5f84b5e27..7437d13ea76702134257f666f8a32ef99130c626 100644
--- a/Source/platform/exported/WebFederatedCredential.cpp
+++ b/Source/platform/exported/WebFederatedCredential.cpp
@@ -8,14 +8,8 @@
#include "platform/credentialmanager/PlatformFederatedCredential.h"
namespace blink {
-WebFederatedCredential::WebFederatedCredential(const WebString& id, const WebURL& federation, const WebString& name, const WebURL& avatarURL)
- : WebCredential(PlatformFederatedCredential::create(id, federation, name, avatarURL))
-{
-}
-
-// FIXME: Throw this away once it's unused on the Chromium side.
-WebFederatedCredential::WebFederatedCredential(const WebString& id, const WebString& name, const WebURL& avatarURL, const WebURL& federation)
- : WebCredential(PlatformFederatedCredential::create(id, federation, name, avatarURL))
+WebFederatedCredential::WebFederatedCredential(const WebString& id, const WebURL& provider, const WebString& name, const WebURL& iconURL)
+ : WebCredential(PlatformFederatedCredential::create(id, provider, name, iconURL))
{
}
@@ -24,9 +18,9 @@ void WebFederatedCredential::assign(const WebFederatedCredential& other)
m_platformCredential = other.m_platformCredential;
}
-WebURL WebFederatedCredential::federation() const
+WebURL WebFederatedCredential::provider() const
{
- return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->federation();
+ return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->provider();
}
WebFederatedCredential::WebFederatedCredential(PlatformCredential* credential)
« no previous file with comments | « Source/platform/credentialmanager/PlatformFederatedCredential.cpp ('k') | public/platform/WebFederatedCredential.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698