Relocate box border painting code into BoxBorderPainter

Relocate box border painting code into BoxBorderPainter

Border painting code is complex enough to warrant a dedicated class.

This is a straight code move, with no functional changes. More
significant changes to follow.

BUG=473119
R=chrishtr@chromium.org,junov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196279

[chrishtr, 2015-06-02 00:48:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-02 00:48:22]

lgtm

[commit-bot: I haz the power, 2015-06-02 00:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162863006/20001

[pdr., 2015-06-02 00:59:55]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2015-06-02 00:59:56]

LGTM

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
File Source/core/paint/BoxBorderPainter.h (right):

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:1: // Copyright 2015 The Chromium Authors.
All rights reserved.
Nit: Not your fault but line lengths are all over the place. Since we're moving
this, can you format the lines to be consistent? (Maybe in the de-static
followup)

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:28: const BorderEdge[], BorderEdgeFlags,
BackgroundBleedAvoidance, bool includeLogicalLeftEdge, bool
includeLogicalRightEdge, bool antialias = false);
The optional antialias value doesn't seem to be used.

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:29: static void
paintOneBorderSide(GraphicsContext*, const ComputedStyle&, const
FloatRoundedRect& outerBorder, const FloatRoundedRect& innerBorder,
The optional overrideColor value doesn't seem to be used.

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:32: static void
paintBorderSides(GraphicsContext*, const ComputedStyle&, const FloatRoundedRect&
outerBorder, const FloatRoundedRect& innerBorder,
The optional antialias value doesn't seem to be used.

[pdr., 2015-06-02 01:00:20]

On 2015/06/02 at 00:50:22, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1162863006/20001

Oops, I was too slow to review. All of my comments are fine in a followup.

[f(malita), 2015-06-02 01:12:54]

On 2015/06/02 01:00:20, pdr wrote:
> On 2015/06/02 at 00:50:22, commit-bot wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1162863006/20001
> 
> Oops, I was too slow to review. All of my comments are fine in a followup.

Thanks, will do.

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
File Source/core/paint/BoxBorderPainter.h (right):

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:1: // Copyright 2015 The Chromium Authors.
All rights reserved.
On 2015/06/02 00:59:56, pdr wrote:
> Nit: Not your fault but line lengths are all over the place. Since we're
moving
> this, can you format the lines to be consistent? (Maybe in the de-static
> followup)

Agreed, will do. I tend to wrap at ~100 whatever I touch, but for this CL I
tried to minimize changes just in case anyone was actually trying to review :).

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:28: const BorderEdge[], BorderEdgeFlags,
BackgroundBleedAvoidance, bool includeLogicalLeftEdge, bool
includeLogicalRightEdge, bool antialias = false);
On 2015/06/02 00:59:56, pdr wrote:
> The optional antialias value doesn't seem to be used.

it's computed in paintBorder() & passed through to paintBorderSides().

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:29: static void
paintOneBorderSide(GraphicsContext*, const ComputedStyle&, const
FloatRoundedRect& outerBorder, const FloatRoundedRect& innerBorder,
On 2015/06/02 00:59:56, pdr wrote:
> The optional overrideColor value doesn't seem to be used.

computed in paintTranslucentBorderSides() & used for colorToPaint calculation.

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:32: static void
paintBorderSides(GraphicsContext*, const ComputedStyle&, const FloatRoundedRect&
outerBorder, const FloatRoundedRect& innerBorder,
On 2015/06/02 00:59:56, pdr wrote:
> The optional antialias value doesn't seem to be used.

ah, if only that was true... my sleep for the last few weeks would have been so
much better :)

(it's passed through to paintOneBorderSide())

[commit-bot: I haz the power, 2015-06-02 01:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 01:15:12]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64696)

[f(malita), 2015-06-02 01:15:49]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-06-02 01:16:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162863006/20001

[pdr., 2015-06-02 01:17:33]

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
File Source/core/paint/BoxBorderPainter.h (right):

https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
Source/core/paint/BoxBorderPainter.h:28: const BorderEdge[], BorderEdgeFlags,
BackgroundBleedAvoidance, bool includeLogicalLeftEdge, bool
includeLogicalRightEdge, bool antialias = false);
On 2015/06/02 at 01:12:53, f(malita) wrote:
> On 2015/06/02 00:59:56, pdr wrote:
> > The optional antialias value doesn't seem to be used.
> 
> it's computed in paintBorder() & passed through to paintBorderSides().

I just mean the optional part: "bool antialias = false" -> "bool antialias".
This is only called with antialias values provided. Similarly for the others.

[f(malita), 2015-06-02 01:18:52]

On 2015/06/02 01:17:33, pdr wrote:
>
https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
> File Source/core/paint/BoxBorderPainter.h (right):
> 
>
https://codereview.chromium.org/1162863006/diff/20001/Source/core/paint/BoxBo...
> Source/core/paint/BoxBorderPainter.h:28: const BorderEdge[], BorderEdgeFlags,
> BackgroundBleedAvoidance, bool includeLogicalLeftEdge, bool
> includeLogicalRightEdge, bool antialias = false);
> On 2015/06/02 at 01:12:53, f(malita) wrote:
> > On 2015/06/02 00:59:56, pdr wrote:
> > > The optional antialias value doesn't seem to be used.
> > 
> > it's computed in paintBorder() & passed through to paintBorderSides().
> 
> I just mean the optional part: "bool antialias = false" -> "bool antialias".
> This is only called with antialias values provided. Similarly for the others.

Doh, got you - will do!

[commit-bot: I haz the power, 2015-06-02 03:28:43]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196279