Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 1162863002: Material PDF: Fix inconsistent behaviour in page selector, update styling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase mistake Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
index fb6ff6cdaa6c09b2e9bea6b2e43c7120f7e0d93e..5086219364ec7c28ce37c80399367fa8471ca271 100644
--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
@@ -9,15 +9,6 @@ Polymer({
properties: {
/**
- * The index of the current page being viewed (0-based).
- */
- index: {
- type: Number,
- value: 0,
- observer: 'indexChanged'
- },
-
- /**
* The number of pages the document contains.
*/
docLength: {
@@ -27,29 +18,21 @@ Polymer({
},
/**
- * The current entry in the input field (1-based).
+ * The current page being viewed (1-based).
*/
pageNo: {
type: String,
- value: '1',
- observer: 'pageNoChanged'
- },
+ value: '1'
+ }
},
- pageNoChanged: function() {
+ pageNoCommitted: function() {
var page = parseInt(this.pageNo);
- if (!isNaN(page) && page != this.index + 1) {
+ if (!isNaN(page)) {
this.fire('change-page', {page: page - 1});
- } else {
- // Repopulate the input.
- this.indexChanged();
}
},
- indexChanged: function() {
- this.pageNo = String(this.index + 1);
- },
-
docLengthChanged: function() {
var numDigits = this.docLength.toString().length;
this.$.pageselector.style.width = (numDigits * DIGIT_LENGTH) + 'em';

Powered by Google App Engine
This is Rietveld 408576698