chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html - Issue 1162863002: Material PDF: Fix inconsistent behaviour in page selector, update styling

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 1162863002: Material PDF: Fix inconsistent behaviour in page selector, update styling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test for shouldIgnoreKeyEvents Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('j') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v0_8/paper-input/paper-input .html">	2 <link rel="import" href="chrome://resources/polymer/v0_8/iron-input/iron-input.h tml">

	3 <link rel="import" href="chrome://resources/polymer/v0_8/paper-input/paper-input -container.html">

3	4

4 <dom-module id="viewer-page-selector">	5 <dom-module id="viewer-page-selector">

5 <link rel="import" type="css" href="viewer-page-selector.css">	6 <link rel="import" type="css" href="viewer-page-selector.css">

6 <template>	7 <template>

7 <paper-input id="pageselector" value="{{pageNo}}" no-label-float></paper-inp ut>	8 <paper-input-container id="pageselector" no-label-float>

	9 <input id="input" is="iron-input" bind-value="{{pageNo}}" on-mouseup="sele ct"

	10 on-change="pageNoCommitted">

	11 </paper-input-container>

8 <span id="pagelength">/ <span>{{docLength}}</span></span>	12 <span id="pagelength">/ <span>{{docLength}}</span></span>

9 </template>	13 </template>

10 </dom-module>	14 </dom-module>

11 <script src="viewer-page-selector.js"></script>	15 <script src="viewer-page-selector.js"></script>

OLD	NEW