Material PDF: Fix inconsistent behaviour in page selector, update styling

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 179 matching lines @@
   this.navigator_ = new Navigator(this.browserApi_.getStreamInfo().originalUrl,
                                   this.viewport_, this.paramsParser_,
                                   onNavigateInCurrentTab, onNavigateInNewTab);
   this.viewportScroller_ =
       new ViewportScroller(this.viewport_, this.plugin_, window);
 }
 
 PDFViewer.prototype = {
   /**
    * @private
+   * Whether keydown events should currently be ignored. Events are ignored when
+   * an editable element has focus, to allow for proper editing controls.
+   * @return {boolean} True if keydown events should be ignored.
+   */
+  shouldIgnoreKeyEvents_: function() {
+    var activeElement = document.activeElement;
+    while (activeElement.shadowRoot != null) {
+      activeElement = activeElement.shadowRoot.activeElement;
+    }

[raymes, 2015/06/02 01:12:04]

nit: no {} to be consistent

[tsergeant, 2015/06/02 05:00:39]

Done.

+
+    return (activeElement.isContentEditable ||
+            activeElement.tagName == 'INPUT' ||
+            activeElement.tagName == 'TEXTAREA');
+  },

[raymes, 2015/06/02 01:12:03]

We should be able to move this out of PDFViewer and put it up the top with the
other standalone functions. You could pass in document.activeElement as a
parameter to make it more encapsulated.

[tsergeant, 2015/06/02 05:00:39]

Done.

+
+  /**
+   * @private
    * Handle key events. These may come from the user directly or via the
    * scripting API.
    * @param {KeyboardEvent} e the event to handle.
    */
   handleKeyEvent_: function(e) {
     var position = this.viewport_.position;
     // Certain scroll events may be sent from outside of the extension.
     var fromScriptingAPI = e.fromScriptingAPI;
 
+    if (this.shouldIgnoreKeyEvents_() || e.defaultPrevented) return;

[raymes, 2015/06/02 01:12:03]

nit: return on a newline

[tsergeant, 2015/06/02 05:00:39]

Done.

+
     var pageUpHandler = function() {
       // Go to the previous page if we are fit-to-page.
       if (this.viewport_.fittingType == Viewport.FittingType.FIT_TO_PAGE) {
         this.viewport_.goToPage(this.viewport_.getMostVisiblePage() - 1);
         // Since we do the movement of the page.
         e.preventDefault();
       } else if (fromScriptingAPI) {
         position.y -= this.viewport.size.height;
         this.viewport.position = position;
       }
@@ skipping 538 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };