Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1162853002: Remove IME API from Blink (Closed)

Created:
4 years, 11 months ago by kochi
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove IME API from Blink This removes all of the W3C IME API implementation along with its tests. The implementation has been under experimental flag for a more than a year and we saw no increasing interest of shipping this, so removing the code from repository for code health. We may readd the code or reimplement the API to the latest spec in the future. This is the second part of the 3-side patch. fist one (Chromium side, landed): https://codereview.chromium.org/1150953003/ last one (Chromium side): https://codereview.chromium.org/1163603004/ BUG=494856 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196281

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : InputMethodController #

Patch Set 4 : rebase #

Patch Set 5 : remove interface in WebWidgets.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1029 lines) Patch
D LayoutTests/fast/events/ime-composition-events-segments.html View 1 chunk +0 lines, -94 lines 0 comments Download
D LayoutTests/fast/events/ime-composition-events-segments-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/fast/ime/candidatewindowevent.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/ime/candidatewindowevent-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/ime/composition-offsets.html View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/fast/ime/composition-offsets-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/ime/html-inputmethodcontext.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/ime/html-inputmethodcontext-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/ime/inputmethodcontext-confirmcomposition.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/fast/ime/inputmethodcontext-confirmcomposition-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M LayoutTests/platform/android/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 3 chunks +0 lines, -17 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 3 chunks +0 lines, -17 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/editing/InputMethodController.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 2 3 3 chunks +5 lines, -21 lines 0 comments Download
M Source/core/events/CompositionEvent.h View 1 2 4 chunks +3 lines, -11 lines 0 comments Download
M Source/core/events/CompositionEvent.cpp View 2 chunks +1 line, -33 lines 0 comments Download
M Source/core/events/CompositionEvent.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/core/html/ime/InputMethodContext.h View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/html/ime/InputMethodContext.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
D Source/core/html/ime/InputMethodContext.idl View 1 chunk +0 lines, -43 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 3 chunks +0 lines, -35 lines 0 comments Download
M public/web/WebWidget.h View 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162853002/1
4 years, 11 months ago (2015-06-01 05:36:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162853002/20001
4 years, 11 months ago (2015-06-01 05:39:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162853002/40001
4 years, 11 months ago (2015-06-01 06:31:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-01 09:29:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162853002/80001
4 years, 11 months ago (2015-06-02 01:28:43 UTC) #11
kochi
Please review this. Thanks.
4 years, 11 months ago (2015-06-02 01:45:27 UTC) #12
tkent
lgtm nit: you might want to remove 'IME' from Source/build/scripts/name_utilities.py.
4 years, 11 months ago (2015-06-02 02:05:51 UTC) #13
kochi
Thanks for the review. On 2015/06/02 02:05:51, tkent wrote: > lgtm > > nit: you ...
4 years, 11 months ago (2015-06-02 02:33:56 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-02 04:12:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162853002/80001
4 years, 11 months ago (2015-06-02 04:16:04 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 04:20:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196281

Powered by Google App Engine
This is Rietveld 408576698